public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Sean Christopherson <seanjc@google.com>
To: Uros Bizjak <ubizjak@gmail.com>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
	Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH] KVM/VMX: Avoid stack engine synchronization uop in __vmx_vcpu_run
Date: Tue, 30 Aug 2022 21:43:28 +0000	[thread overview]
Message-ID: <Yw6EgFOcnCGa5hOo@google.com> (raw)
In-Reply-To: <20220816211010.25693-1-ubizjak@gmail.com>

On Tue, Aug 16, 2022, Uros Bizjak wrote:
> Avoid instructions with explicit uses of the stack pointer between
> instructions that implicitly refer to it. The sequence of
> POP %reg; ADD $x, %RSP; POP %reg forces emission of synchronization
> uop to synchronize the value of the stack pointer in the stack engine
> and the out-of-order core.
> 
> Using POP with the dummy register instead of ADD $x, %RSP results in a
> smaller code size and faster code.
> 
> The patch also fixes the reference to the wrong register in the
> nearby comment.
> 
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Cc: Sean Christopherson <seanjc@google.com>
> Signed-off-by: Uros Bizjak <ubizjak@gmail.com>
> ---

Pushed to branch `for_paolo/6.1` at:

    https://github.com/sean-jc/linux.git

Unless you hear otherwise, it will make its way to kvm/queue "soon".

Note, the commit IDs are not guaranteed to be stable.

      reply	other threads:[~2022-08-30 21:43 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-16 21:10 [PATCH] KVM/VMX: Avoid stack engine synchronization uop in __vmx_vcpu_run Uros Bizjak
2022-08-30 21:43 ` Sean Christopherson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yw6EgFOcnCGa5hOo@google.com \
    --to=seanjc@google.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=ubizjak@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox