From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64489C00140 for ; Wed, 24 Aug 2022 15:47:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239942AbiHXPq5 (ORCPT ); Wed, 24 Aug 2022 11:46:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38448 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239677AbiHXPqi (ORCPT ); Wed, 24 Aug 2022 11:46:38 -0400 Received: from mail-pf1-x429.google.com (mail-pf1-x429.google.com [IPv6:2607:f8b0:4864:20::429]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C8A865018A for ; Wed, 24 Aug 2022 08:44:39 -0700 (PDT) Received: by mail-pf1-x429.google.com with SMTP id 1so9666529pfu.0 for ; Wed, 24 Aug 2022 08:44:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc; bh=2pPtfMEoZDm3WYXQlzOmfOlCxFAjiTkNGfWAjxlIOxM=; b=afdirNYp5krv4z3K3/WY/agF8lE75RVBe2jY5/KAOda/8S3JpR8w86X93+To0eEjOd uFROoqBcWZvlAhqWsieUHDqSPOhs1DXxsGy5uka/HfajELHdXLcLip5zMYoNmWYqWwPq /Co3mrQtrIw6Q2siFM+N0Z5Rcw9h7ftgWeQDCs8m2ow1XIekj/fbbUNMQ2VARuNlT/Dk VHqkRAgZiO4XWqyTKPW89JfhDYWIr8mAHJnE2pYokD//binR9WMoKcii/q57r6tULLeh vCuehgjSzBV2jda0Wh7L3zGJhHVjmB40G1pDF9fMO3Zh7BqqUKWzhzlc7CkbJUuLROUL hlZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc; bh=2pPtfMEoZDm3WYXQlzOmfOlCxFAjiTkNGfWAjxlIOxM=; b=8CaJHWuKIEpydP4JGyQpxj/367RYEFZ6ILWkLp23vJuMhPmyML5XN37LEhFMxi9DQf rF6r2Tjy4Ya2ce1/o5a2ompkbmNhzJqsNi/CNBZKC/aqnwdeFjAaHcL/pU7kJ57Ou4dR 8thNW+DxSmmcboSDrPorEVBMZc54DZzI2JK17hmSD1ni5tINSmLK5F2YZLsoE92gMJGa 6e1KHt6sY3ougYlkxCusIlSgUqN91la3R8+u56XaGMF6G+gEm9QuMwswbCogTKMc+Be/ DsOebbH/2S4M4ediFrPQXWvDgH/YDH99XtskJg4ThdV/Li+2qZCpzu2QPgxcLgTAIQOH u69w== X-Gm-Message-State: ACgBeo34YZFFOZAEe8oHnqBu6xtqxvygkgQuF5YGmaoHoXvPYCs24z+L sJ3pTnfCo4vYJiIpLTfs/mpGEg== X-Google-Smtp-Source: AA6agR5h33LQ7obhj8YPbwYHA1KIj00HcSnYRZqrWQiu25FM829oQKEjLdqhCqq3jfixr/uwSSjnvA== X-Received: by 2002:a63:81c8:0:b0:429:ea8c:3afa with SMTP id t191-20020a6381c8000000b00429ea8c3afamr24502319pgd.22.1661355877881; Wed, 24 Aug 2022 08:44:37 -0700 (PDT) Received: from google.com (7.104.168.34.bc.googleusercontent.com. [34.168.104.7]) by smtp.gmail.com with ESMTPSA id u10-20020a17090341ca00b001730f3f4ab4sm2620181ple.217.2022.08.24.08.44.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Aug 2022 08:44:37 -0700 (PDT) Date: Wed, 24 Aug 2022 15:44:33 +0000 From: Sean Christopherson To: Miaohe Lin Cc: pbonzini@redhat.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] kvm: x86: mmu: fix memoryleak in kvm_mmu_vendor_module_init() Message-ID: References: <20220823063237.47299-1-linmiaohe@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220823063237.47299-1-linmiaohe@huawei.com> Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org Nit for future patches, please use KVM: x86/mmu: for the scope. On Tue, Aug 23, 2022, Miaohe Lin wrote: > When register_shrinker() fails, we forgot to release the percpu counter > kvm_total_used_mmu_pages leading to memoryleak. Fix this issue by calling > percpu_counter_destroy() when register_shrinker() fails. > > Fixes: ab271bd4dfd5 ("x86: kvm: propagate register_shrinker return code") > Signed-off-by: Miaohe Lin > --- Reviewed-by: Sean Christopherson