From: Peter Xu <peterx@redhat.com>
To: Emanuele Giuseppe Esposito <eesposit@redhat.com>
Cc: qemu-devel@nongnu.org, "Paolo Bonzini" <pbonzini@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Cornelia Huck" <cohuck@redhat.com>,
"David Hildenbrand" <david@redhat.com>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Maxim Levitsky" <mlevitsk@redhat.com>,
kvm@vger.kernel.org
Subject: Re: [RFC PATCH 1/2] softmmu/memory: add missing begin/commit callback calls
Date: Fri, 26 Aug 2022 10:13:47 -0400 [thread overview]
Message-ID: <YwjVG+MR8ORLngjd@xz-m1.local> (raw)
In-Reply-To: <e5935ba7-dd60-b914-3b1d-fff4f8c01da3@redhat.com>
On Fri, Aug 26, 2022 at 03:53:09PM +0200, Emanuele Giuseppe Esposito wrote:
> What do you mean "will empty all regions with those listeners"?
> But yes theoretically vhost-vdpa and physmem have commit callbacks that
> are independent from whether region_add or other callbacks have been called.
> For kvm and probably vhost it would be no problem, since there won't be
> any list to iterate on.
Right, begin()/commit() is for address space update, so it should be fine
to have nothing to commit, sorry.
>
> I'll implement a new macro to handle this.
Sounds good. Thanks,
--
Peter Xu
next prev parent reply other threads:[~2022-08-26 14:13 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-16 10:12 [RFC PATCH 0/2] accel/kvm: extend kvm memory listener to support Emanuele Giuseppe Esposito
2022-08-16 10:12 ` [RFC PATCH 1/2] softmmu/memory: add missing begin/commit callback calls Emanuele Giuseppe Esposito
2022-08-18 19:34 ` Peter Xu
2022-08-26 13:53 ` Emanuele Giuseppe Esposito
2022-08-26 14:13 ` Peter Xu [this message]
2022-08-27 21:03 ` Peter Xu
2022-09-09 8:02 ` Emanuele Giuseppe Esposito
2022-08-16 10:12 ` [RFC PATCH 2/2] kvm/kvm-all.c: listener should delay kvm_vm_ioctl to the commit phase Emanuele Giuseppe Esposito
2022-08-18 20:04 ` Peter Xu
2022-08-19 0:55 ` Leonardo Bras Soares Passos
2022-08-22 14:10 ` Peter Xu
2022-08-26 14:07 ` Emanuele Giuseppe Esposito
2022-08-27 20:58 ` Peter Xu
2022-08-30 10:59 ` David Hildenbrand
2022-09-09 8:02 ` Emanuele Giuseppe Esposito
2022-09-09 11:02 ` David Hildenbrand
2022-09-09 8:00 ` Emanuele Giuseppe Esposito
2022-08-22 9:08 ` Cornelia Huck
2022-08-26 13:53 ` Emanuele Giuseppe Esposito
2022-08-26 14:15 ` David Hildenbrand
2022-08-26 14:32 ` Emanuele Giuseppe Esposito
2022-08-26 14:44 ` David Hildenbrand
2022-09-09 8:04 ` Emanuele Giuseppe Esposito
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YwjVG+MR8ORLngjd@xz-m1.local \
--to=peterx@redhat.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=eesposit@redhat.com \
--cc=f4bug@amsat.org \
--cc=kvm@vger.kernel.org \
--cc=mlevitsk@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox