From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB7C7ECAAD6 for ; Fri, 26 Aug 2022 20:20:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344897AbiHZUUL (ORCPT ); Fri, 26 Aug 2022 16:20:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40502 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231645AbiHZUUH (ORCPT ); Fri, 26 Aug 2022 16:20:07 -0400 Received: from mail-pf1-x435.google.com (mail-pf1-x435.google.com [IPv6:2607:f8b0:4864:20::435]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EF0463335A for ; Fri, 26 Aug 2022 13:20:04 -0700 (PDT) Received: by mail-pf1-x435.google.com with SMTP id f17so2537348pfk.11 for ; Fri, 26 Aug 2022 13:20:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc; bh=Yy3h91/LZL0yMN3Y+gPnYCc8uzqqu6+PEMw/uYOkvrQ=; b=QI2iqRq9/94E6zl7r9mZw4F+7Daqhq8WErAzs7MCXRZvrz4GpEbY7Dstc+ZZ2JEyb2 q0xcA8xKqPk01eYmQLRlBIm9I9enL9gle1pvxTgv3hEVqdUw5C4cSi7lwuKtIjcxf5KZ MNemfeMqo0zzfRvxEdPkaXJq+V0CXBJoNhrKZhmH2a/6fEvyddf2Pci6F7c3hz5Uh2KZ p9XfmAZB3QDZNhI51WLuUsrX5a34H43X0h0MgNESMM7lb3mZRO5lRiW8QfXtTjK0Iio8 Bx/faeNKIHAHpdLZt2Qt47/Jnw19TxwGoB6eZJ5V4qbulyod0s+zhEZ6nWzqexbUBQl1 6MGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc; bh=Yy3h91/LZL0yMN3Y+gPnYCc8uzqqu6+PEMw/uYOkvrQ=; b=Mx9eLk+nBxC8pZcQSB6FPX/6ydmygKls/v4Z8SbrO1AQg7b07ieG/W00MA1AuT1XZH j8KcVCf2Or230mC52aAFBro6ppJZYW4UbWabWQMyod7mRkRfBZB/k0jfnkmbCRbidCqG tlpoK0gl5gi4zawV7KrzsoqrcZ+PDst9MIqMiXsRWy72kKNbl6RfJySD1uXr2KKEqTa3 JryEDvNxMjgbKrCbOiV081wI3KTujY8v8iIa5ubg4MiP1pYkRoQTQOF8aY3oD791Tko6 BcteAQRZgE89T1gYaRRTB7FI4kxiWFg9UGYk1XA1nUBxt2OA84yWEG3Q75+y7cTEX63G Ptng== X-Gm-Message-State: ACgBeo2dXM1O/nGIYQJTDrDZeIb1K/ypPNiAOYGTzeci7SM2RCx4ey1d YtUzJ6ojkB00hjAWck8jkqVPtw== X-Google-Smtp-Source: AA6agR5n02jhbK1nhPu/jZhpJFX2d1euSOaYUkGIxcjNNi+QlVmGNtQ1h1+3uTxVaQGYEwd8dNh3mw== X-Received: by 2002:a05:6a00:4147:b0:52e:2d56:17c8 with SMTP id bv7-20020a056a00414700b0052e2d5617c8mr5478964pfb.51.1661545204289; Fri, 26 Aug 2022 13:20:04 -0700 (PDT) Received: from google.com (7.104.168.34.bc.googleusercontent.com. [34.168.104.7]) by smtp.gmail.com with ESMTPSA id x21-20020a63f715000000b0042b117e8bf8sm1843703pgh.23.2022.08.26.13.20.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Aug 2022 13:20:03 -0700 (PDT) Date: Fri, 26 Aug 2022 20:20:00 +0000 From: Sean Christopherson To: Yosry Ahmed Cc: Tejun Heo , Johannes Weiner , Zefan Li , Marc Zyngier , James Morse , Alexandru Elisei , Suzuki K Poulose , Paolo Bonzini , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Andrew Morton , Michal Hocko , Roman Gushchin , Shakeel Butt , Oliver Upton , Huang@google.com, Shaoqin , cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v7 3/4] KVM: x86/mmu: count KVM mmu usage in secondary pagetable stats. Message-ID: References: <20220823004639.2387269-1-yosryahmed@google.com> <20220823004639.2387269-4-yosryahmed@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220823004639.2387269-4-yosryahmed@google.com> Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Tue, Aug 23, 2022, Yosry Ahmed wrote: > Count the pages used by KVM mmu on x86 in memory stats under secondary > pagetable stats (e.g. "SecPageTables" in /proc/meminfo) to give better > visibility into the memory consumption of KVM mmu in a similar way to > how normal user page tables are accounted. > > Signed-off-by: Yosry Ahmed > Reviewed-by: Sean Christopherson > --- > arch/x86/kvm/mmu/mmu.c | 16 ++++++++++++++-- > arch/x86/kvm/mmu/tdp_mmu.c | 12 ++++++++++++ > 2 files changed, 26 insertions(+), 2 deletions(-) > > diff --git a/arch/x86/kvm/mmu/mmu.c b/arch/x86/kvm/mmu/mmu.c > index e418ef3ecfcb..4d38e4eba772 100644 > --- a/arch/x86/kvm/mmu/mmu.c > +++ b/arch/x86/kvm/mmu/mmu.c > @@ -1665,6 +1665,18 @@ static inline void kvm_mod_used_mmu_pages(struct kvm *kvm, long nr) > percpu_counter_add(&kvm_total_used_mmu_pages, nr); > } > > +static void kvm_account_mmu_page(struct kvm *kvm, struct kvm_mmu_page *sp) > +{ > + kvm_mod_used_mmu_pages(kvm, +1); > + kvm_account_pgtable_pages((void *)sp->spt, +1); > +} > + > +static void kvm_unaccount_mmu_page(struct kvm *kvm, struct kvm_mmu_page *sp) > +{ > + kvm_mod_used_mmu_pages(kvm, -1); > + kvm_account_pgtable_pages((void *)sp->spt, -1); > +} Hrm, this is causing build on x86 issues for me. AFAICT, modpost doesn't detect that this creates a new module dependency on __mod_lruvec_page_state() and so doesn't refresh vmlinux.symvers. ERROR: modpost: "__mod_lruvec_page_state" [arch/x86/kvm/kvm.ko] undefined! make[2]: *** [scripts/Makefile.modpost:128: modules-only.symvers] Error 1 make[1]: *** [Makefile:1769: modules] Error 2 make[1]: *** Waiting for unfinished jobs.... Kernel: arch/x86/boot/bzImage is ready (#128) make[1]: Leaving directory '/usr/local/google/home/seanjc/build/kernel/vm' make: *** [Makefile:222: __sub-make] Error 2 Both gcc and clang yield the same behavior, so I doubt it's the compiler doing something odd. Cleaning the build makes the problem go away, but that's a poor band-aid. If I squash this with the prior patch that adds kvm_account_pgtable_pages() to kvm_host.h, modpost detects the need to refresh and all is well. Given that ARM doesn't support building KVM as a module, i.e. can't run afoul of whatever modpost weirdness I'm hitting, I'm inclined to squash this with the previous patch and punt on the modpost issue so that we can get this merged. Any objections? Or thoughts on what's going wrong?