From: Jason Gunthorpe <jgg@nvidia.com>
To: "Tian, Kevin" <kevin.tian@intel.com>
Cc: Alex Williamson <alex.williamson@redhat.com>,
Cornelia Huck <cohuck@redhat.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"llvm@lists.linux.dev" <llvm@lists.linux.dev>,
Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
Tom Rix <trix@redhat.com>
Subject: Re: [PATCH 7/8] vfio: Follow the naming pattern for vfio_group_ioctl_unset_container()
Date: Mon, 29 Aug 2022 12:28:07 -0300 [thread overview]
Message-ID: <YwzbB5NZGOqOsOVK@nvidia.com> (raw)
In-Reply-To: <BN9PR11MB5276B0A8F6DD36C6482F37038C769@BN9PR11MB5276.namprd11.prod.outlook.com>
On Mon, Aug 29, 2022 at 12:41:30AM +0000, Tian, Kevin wrote:
> > From: Jason Gunthorpe <jgg@nvidia.com>
> > Sent: Thursday, August 18, 2022 12:07 AM
> >
> > Make it clear that this is the body of the ioctl - keep the mutex outside
> > the function since this function doesn't have and wouldn't benefit from
> > error unwind.
>
> but doing so make unset_container() unpair with set_container() and
> be the only one doing additional things in main ioctl body.
>
> I'd prefer to moving mutex inside unset_container() for better readability.
Yes, I tried both ways and ended up here since adding the goto unwind
was kind of ungainly for this function. Don't mind either way
The functions are not intended as strict pairs, they are ioctl
dispatch functions.
Jason
next prev parent reply other threads:[~2022-08-29 15:28 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-17 16:07 [PATCH 0/8] Break up ioctl dispatch functions to one function per ioctl Jason Gunthorpe
2022-08-17 16:07 ` [PATCH 1/8] vfio-pci: Fix vfio_pci_ioeventfd() to return int Jason Gunthorpe
2022-08-29 0:30 ` Tian, Kevin
2022-08-17 16:07 ` [PATCH 2/8] vfio-pci: Break up vfio_pci_core_ioctl() into one function per ioctl Jason Gunthorpe
2022-08-29 0:31 ` Tian, Kevin
2022-08-29 0:37 ` Tian, Kevin
2022-08-17 16:07 ` [PATCH 3/8] vfio-pci: Re-indent what was vfio_pci_core_ioctl() Jason Gunthorpe
2022-08-29 0:32 ` Tian, Kevin
2022-08-29 0:37 ` Tian, Kevin
2022-08-17 16:07 ` [PATCH 4/8] vfio-pci: Replace 'void __user *' with proper types in the ioctl functions Jason Gunthorpe
2022-08-29 0:35 ` Tian, Kevin
2022-08-29 0:38 ` Tian, Kevin
2022-08-17 16:07 ` [PATCH 5/8] vfio: Fold VFIO_GROUP_GET_DEVICE_FD into vfio_group_get_device_fd() Jason Gunthorpe
2022-08-29 0:36 ` Tian, Kevin
2022-08-17 16:07 ` [PATCH 6/8] vfio: Fold VFIO_GROUP_SET_CONTAINER into vfio_group_set_container() Jason Gunthorpe
2022-08-29 0:39 ` Tian, Kevin
2022-08-17 16:07 ` [PATCH 7/8] vfio: Follow the naming pattern for vfio_group_ioctl_unset_container() Jason Gunthorpe
2022-08-29 0:41 ` Tian, Kevin
2022-08-29 15:28 ` Jason Gunthorpe [this message]
2022-08-30 16:42 ` Alex Williamson
2022-08-30 16:51 ` Jason Gunthorpe
2022-08-31 17:48 ` Alex Williamson
2022-08-17 16:07 ` [PATCH 8/8] vfio: Split VFIO_GROUP_GET_STATUS into a function Jason Gunthorpe
2022-08-26 23:43 ` Jason Gunthorpe
2022-08-30 16:43 ` Alex Williamson
2022-08-29 0:43 ` Tian, Kevin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YwzbB5NZGOqOsOVK@nvidia.com \
--to=jgg@nvidia.com \
--cc=alex.williamson@redhat.com \
--cc=cohuck@redhat.com \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox