From: Sean Christopherson <seanjc@google.com>
To: Miaohe Lin <linmiaohe@huawei.com>
Cc: pbonzini@redhat.com, tglx@linutronix.de, mingo@redhat.com,
bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org,
hpa@zytor.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] KVM: x86/mmu: add missing update to max_mmu_rmap_size
Date: Wed, 7 Sep 2022 14:26:57 +0000 [thread overview]
Message-ID: <YxiqMbQlZJqxzu2q@google.com> (raw)
In-Reply-To: <20220907080657.42898-1-linmiaohe@huawei.com>
On Wed, Sep 07, 2022, Miaohe Lin wrote:
> The update to statistic max_mmu_rmap_size is unintentionally removed by
> commit 4293ddb788c1 ("KVM: x86/mmu: Remove redundant spte present check
> in mmu_set_spte"). Add missing update to it or max_mmu_rmap_size will
> always be nonsensical 0.
>
> Fixes: 4293ddb788c1 ("KVM: x86/mmu: Remove redundant spte present check in mmu_set_spte")
For anyone else wondering "how did so many reviewers miss this obvious bug?", the
answer is that the reviews were collected for v3 and earlier, and the mishandled
merge conflict only showed up in v4.
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
> ---
Reviewed-by: Sean Christopherson <seanjc@google.com>
Paolo, do you want to grab this for 6.0?
next prev parent reply other threads:[~2022-09-07 14:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-07 8:06 [PATCH] KVM: x86/mmu: add missing update to max_mmu_rmap_size Miaohe Lin
2022-09-07 14:26 ` Sean Christopherson [this message]
2022-09-22 21:03 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YxiqMbQlZJqxzu2q@google.com \
--to=seanjc@google.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=kvm@vger.kernel.org \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox