From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3EE39C6FA82 for ; Tue, 20 Sep 2022 16:58:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229865AbiITQ6W (ORCPT ); Tue, 20 Sep 2022 12:58:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46406 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229631AbiITQ6U (ORCPT ); Tue, 20 Sep 2022 12:58:20 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3C056286D8 for ; Tue, 20 Sep 2022 09:58:20 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id CB0BC61489 for ; Tue, 20 Sep 2022 16:58:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E0860C433C1; Tue, 20 Sep 2022 16:58:16 +0000 (UTC) Date: Tue, 20 Sep 2022 17:58:13 +0100 From: Catalin Marinas To: Marc Zyngier Cc: kernel test robot , Peter Collingbourne , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kbuild-all@lists.01.org, Cornelia Huck , Will Deacon , Evgenii Stepanov , kvm@vger.kernel.org, Steven Price , Vincenzo Frascino Subject: Re: [PATCH v3 3/7] mm: Add PG_arch_3 page flag Message-ID: References: <20220810193033.1090251-4-pcc@google.com> <202208111500.62e0Bl2l-lkp@intel.com> <878rmfkzbu.wl-maz@kernel.org> <871qs6kntl.wl-maz@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <871qs6kntl.wl-maz@kernel.org> Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Tue, Sep 20, 2022 at 05:33:42PM +0100, Marc Zyngier wrote: > On Tue, 20 Sep 2022 16:39:47 +0100, > Catalin Marinas wrote: > > On Mon, Sep 19, 2022 at 07:12:53PM +0100, Marc Zyngier wrote: > > > On Mon, 05 Sep 2022 18:01:55 +0100, > > > Catalin Marinas wrote: > > > > Peter, please let me know if you want to pick this series up together > > > > with your other KVM patches. Otherwise I can post it separately, it's > > > > worth merging it on its own as it clarifies the page flag vs tag setting > > > > ordering. > > > > > > I'm looking at queuing this, but I'm confused by this comment. Do I > > > need to pick this as part of the series? Or is this an independent > > > thing (my hunch is that it is actually required not to break other > > > architectures...). > > > > This series series (at least the first patches) won't apply cleanly on > > top of 6.0-rc1 and, of course, we shouldn't break other architectures. I > > can repost the whole series but I don't have the setup to test the > > MAP_SHARED KVM option (unless Peter plans to post it soon). > > I don't feel brave enough to take a series affecting all architectures It shouldn't affect the others, the only change is that PG_arch_2 is now only defined for arm64 but no other architecture is using it. The problem with loongarch is that it doesn't have enough spare bits in page->flags and even without any patches I think it's broken with the right value for NR_CPUS. > so late in the game, and the whole thing had very little arm64 > exposure. The latest QEMU doesn't seem to work anymore, so I don't > have any MTE-capable emulation (and using the FVP remotely is a pain > in the proverbial neck). > > I'll come back to this after the merge window, should Peter decide to > respin the series. It makes sense. -- Catalin