public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Sean Christopherson <seanjc@google.com>
To: Hou Wenlong <houwenlong.hwl@antgroup.com>
Cc: kvm@vger.kernel.org
Subject: Re: [PATCH v2 0/2] Add missing trace points in emulator path
Date: Tue, 20 Sep 2022 22:12:22 +0000	[thread overview]
Message-ID: <Yyo6xqWO1G9wIn7Y@google.com> (raw)
In-Reply-To: <cover.1661930557.git.houwenlong.hwl@antgroup.com>

On Fri, Sep 02, 2022, Hou Wenlong wrote:
> Some existed trace points are missing in emulator path, e.g.,
> RDMSR/WRMSR emulation and CR read/write emulation. However,
> if add those trace points in emulator common interfaces in
> arch/x86/kvm/x86.c, other instruction emulation may use those
> interfaces too and cause too much trace records. But add those
> trace points in em_* functions in arch/x86/kvm/emulate.c seems
> to be ugly. Luckily, RDMSR/WRMSR emulation uses a sepreate
> interface, so add trace points for RDMSR/WRMSR in emulator
> path is acceptable like normal path.
> 
> Changed from v1:
> - As Sean suggested, use X86EMUL_PROPAGATE_FAULT instead of
>   X86EMUL_UNHANDLEABLE for error path.
> - As Sean suggested, move "r < 0" handling into the set helper,
>   and add "r < 0" check in the get helper.
> 
> v1: https://lore.kernel.org/kvm/cover.1658913543.git.houwenlong.hwl@antgroup.com
> 
> Hou Wenlong (2):
>   KVM: x86: Return emulator error if RDMSR/WRMSR emulation failed
>   KVM: x86: Add missing trace points for RDMSR/WRMSR in emulator path

Pushed to branch `for_paolo/6.1` at:

    https://github.com/sean-jc/linux.git

Unless you hear otherwise, it will make its way to kvm/queue "soon".

      parent reply	other threads:[~2022-09-20 22:12 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-02  2:46 [PATCH v2 0/2] Add missing trace points in emulator path Hou Wenlong
2022-09-02  2:47 ` [PATCH v2 1/2] KVM: x86: Return emulator error if RDMSR/WRMSR emulation failed Hou Wenlong
2022-09-02  2:47 ` [PATCH v2 2/2] KVM: x86: Add missing trace points for RDMSR/WRMSR in emulator path Hou Wenlong
2022-09-20 22:12 ` Sean Christopherson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yyo6xqWO1G9wIn7Y@google.com \
    --to=seanjc@google.com \
    --cc=houwenlong.hwl@antgroup.com \
    --cc=kvm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox