Re: [kvm-unit-tests RFC PATCH 1/5] efi: Compile standalone binaries for EFI

[Sean Christopherson <seanjc@google.com>]

On Tue, Aug 16, 2022, Zixuan Wang wrote:
> Currently the standalone binaries do not work with EFI as the scripts
> are not aware of EFI-related files. More specifically, the scripts only
> search for .flat files, but EFI binaries are .efi files.
> 
> This patch fixes this by introducing a new 'efi' option for

Avoid this patch, and phrase changelogs as command.  E.g.

  Introduce an "efi" option in unittests.cfg <reasoning...>

> unittests.cfg. This patch does not contain any modifications to use this
> new efi option. Those updates will be folded into the follow-up patch.
> 
> Signed-off-by: Zixuan Wang <zxwang@fb.com>
> ---
>  scripts/common.bash     | 24 ++++++++++++++++++++++--
>  scripts/mkstandalone.sh | 17 ++++++++++++++++-
>  x86/unittests.cfg       |  3 +++
>  3 files changed, 41 insertions(+), 3 deletions(-)
> 
> diff --git a/scripts/common.bash b/scripts/common.bash
> index 7b983f7..7af9d62 100644
> --- a/scripts/common.bash
> +++ b/scripts/common.bash
> @@ -1,5 +1,21 @@
>  source config.mak
>  
> +function unittest_enabled()
> +{
> +	test_name="$1"
> +	test_efi="$2"
> +
> +	if [ -z "${test_name}" ]; then
> +		false
> +	elif [ "${CONFIG_EFI}" == "y" ] && [ "${test_efi}" == "no" ]; then
> +		false
> +	elif [ "${CONFIG_EFI}" == "n" ] && [ "${test_efi}" == "only" ]; then

Having to tag every test as EFI-friendly is going to get annoying, and without
context it's not super obvious that "efi = yes" means EFI-friendly _and_ legacy-
friendly.

Rather than "efi = {yes,no,only}", what about "efi = {unsupported,required}"?
I.e. tag only tests that don't support all flavors of firmware.