From: Sean Christopherson <seanjc@google.com>
To: Zixuan Wang <zxwang@fb.com>
Cc: kvm@vger.kernel.org, pbonzini@redhat.com, drjones@redhat.com,
shankaran@fb.com, somnathc@fb.com, marcorr@google.com,
varad.gautam@suse.com, jroedel@suse.de, bp@suse.de,
zxwang42@gmail.com
Subject: Re: [kvm-unit-tests RFC PATCH 2/5] x86/efi: Fix efi runner scripts for standalone
Date: Wed, 5 Oct 2022 18:24:58 +0000 [thread overview]
Message-ID: <Yz3L+nZv8ozvZ/z3@google.com> (raw)
In-Reply-To: <20220816175413.3553795-3-zxwang@fb.com>
On Tue, Aug 16, 2022, Zixuan Wang wrote:
> Fix the efi runner scripts to run in the standalone mode:
Capitalize EFI for consistency.
> 1. Define the `x86/run` qemu runner as a function because `x86/run` is
> embedded into the standalone and cannot be called using its file name.
>
> 2. Disabling the `config.mak` checks in the standalone mode as it's not
> available.
s/Disabling/Disable
>
> 3. Use the dummy test file name provided by standalone's EFI_DUMMY
> variable, because the dummy test case is embedded into the standalone
> files and exported as a tmp file at run time.
This patch probably needs to be split into three patches, one for each of the
above changes. A changelog that contains a list of things that are fixed is usually
a good hint that the patch is bundling too many things together.
next prev parent reply other threads:[~2022-10-05 18:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220816175413.3553795-1-zxwang@fb.com>
[not found] ` <20220816175413.3553795-2-zxwang@fb.com>
2022-10-05 18:20 ` [kvm-unit-tests RFC PATCH 1/5] efi: Compile standalone binaries for EFI Sean Christopherson
[not found] ` <20220816175413.3553795-3-zxwang@fb.com>
2022-10-05 18:24 ` Sean Christopherson [this message]
[not found] ` <20220816175413.3553795-4-zxwang@fb.com>
2022-10-05 18:34 ` [kvm-unit-tests RFC PATCH 3/5] x86/efi: Update unittests.cfg to build standalones Sean Christopherson
[not found] ` <20220816175413.3553795-6-zxwang@fb.com>
2022-10-05 18:38 ` [kvm-unit-tests RFC PATCH 5/5] x86/efi: Update README with standalone instructions Sean Christopherson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yz3L+nZv8ozvZ/z3@google.com \
--to=seanjc@google.com \
--cc=bp@suse.de \
--cc=drjones@redhat.com \
--cc=jroedel@suse.de \
--cc=kvm@vger.kernel.org \
--cc=marcorr@google.com \
--cc=pbonzini@redhat.com \
--cc=shankaran@fb.com \
--cc=somnathc@fb.com \
--cc=varad.gautam@suse.com \
--cc=zxwang42@gmail.com \
--cc=zxwang@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox