From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54F42C04A95 for ; Wed, 28 Sep 2022 23:05:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232827AbiI1XFg (ORCPT ); Wed, 28 Sep 2022 19:05:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44820 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229486AbiI1XFe (ORCPT ); Wed, 28 Sep 2022 19:05:34 -0400 Received: from mail-pl1-x632.google.com (mail-pl1-x632.google.com [IPv6:2607:f8b0:4864:20::632]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 365BA11C26 for ; Wed, 28 Sep 2022 16:05:33 -0700 (PDT) Received: by mail-pl1-x632.google.com with SMTP id c24so12969855plo.3 for ; Wed, 28 Sep 2022 16:05:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=PAmyKBlgjtbvtqhVxXHx2ejMGzjNRJ+Srms5+P+ez64=; b=DKwecanPirQPKezM3JUZXVruK+2m/GK9uMx0vqcCuSKCTTJmFBrkaAZ9T0tlg+T4ZF oQXWRzqs0ArkQ/CirhQV9zXks0YSjINnPFWsYKq4k5nHhxf4qCVj+JwcSUOUQCojKPxL AuQtpFX8q3L91jdd6FeHYvLKiiSokP2f87P1T7OMC5+wNmV3mBdxDMrEjLPds+5dcP4h FPFl9p5AS68AbIFWNHS4rQVoQiVp/IAX76cgVhj+fySATYBdGdnHrB7iWzeLe+g0fMzt DN8eO45YSiiSO7SrIvjjplWrFdi+PuzpyeEtcCRpAcDL8sYDDZrLW6ZQttuju8dTmtea 6upA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=PAmyKBlgjtbvtqhVxXHx2ejMGzjNRJ+Srms5+P+ez64=; b=ItrVEIZ35H7kGwH1b3jQ6Ikda3REjP1pil4XfHobUQa/91w0k/+9LUpeNaBuzH8QOQ CLfwUw+2nDKPjQtqa0nyJsXfJdzDQClVCHsNAr82jdM71Dii+cgyB4ERImoadDYlIgl6 jlil+ves8PcilCVljEuc19pqGcx2G4Zcf5D971QJvtdT2a2mCDqWbaFJ4OIOJQCPcUR0 lGpNfHm/VJ4iqr4Fk6jgP1b7qzY1LYcYnFuSaMWp7jonj+ElT2z1x1DhmJLzGGhDfqQE Hpu2KYVtKrsKiIZGVycMBZLyJ76jvO2/H9fUSsoNiubyvaL1n3cWkfyps+H1bz3QhfeS X2Ng== X-Gm-Message-State: ACrzQf3NEmOj/uvWX0YcWCAImz5sHrZSe+gMqKjWvkCx9xFCq9mWUZP4 z/wZPezzwGb9/Tmzr90njPjPc/yUVZHfaQ== X-Google-Smtp-Source: AMsMyM7mVBjUViDKxT1spfFBekYzPo0peBmP6JK8BMtco2twxx71XTEXbyqSX07T43HGN2Z4b2DR2Q== X-Received: by 2002:a17:90a:7088:b0:200:4e9f:a206 with SMTP id g8-20020a17090a708800b002004e9fa206mr12559534pjk.173.1664406332642; Wed, 28 Sep 2022 16:05:32 -0700 (PDT) Received: from google.com (7.104.168.34.bc.googleusercontent.com. [34.168.104.7]) by smtp.gmail.com with ESMTPSA id c13-20020a170902d48d00b001782751833bsm4329897plg.223.2022.09.28.16.05.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Sep 2022 16:05:32 -0700 (PDT) Date: Wed, 28 Sep 2022 23:05:28 +0000 From: Sean Christopherson To: David Matlack Cc: Paolo Bonzini , Ben Gardon , kvm@vger.kernel.org, Andrew Jones , Colton Lewis , Ricardo Koller Subject: Re: [PATCH 2/2] KVM: selftests: Rename perf_test_util symbols to memstress Message-ID: References: <20220919232300.1562683-1-dmatlack@google.com> <20220919232300.1562683-3-dmatlack@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220919232300.1562683-3-dmatlack@google.com> Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Mon, Sep 19, 2022, David Matlack wrote: > @@ -42,10 +42,10 @@ static struct kvm_vcpu *vcpus[KVM_MAX_VCPUS]; > * Continuously write to the first 8 bytes of each page in the > * specified region. > */ > -void perf_test_guest_code(uint32_t vcpu_idx) > +void memstress_guest_code(uint32_t vcpu_idx) > { > - struct perf_test_args *pta = &perf_test_args; > - struct perf_test_vcpu_args *vcpu_args = &pta->vcpu_args[vcpu_idx]; > + struct memstress_args *ma = &memstress_args; As a prep patch, what about renaming pta=>args? I always struggle to remember what "pta" means, and "ma" isn't any better. And that would give some amount of alignment between "args" and "vcpu_args". At a glance, I don't think using a generic name like that will be problematic.