From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0EF2FC433F5 for ; Tue, 4 Oct 2022 08:05:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229630AbiJDIF4 (ORCPT ); Tue, 4 Oct 2022 04:05:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45002 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229547AbiJDIFq (ORCPT ); Tue, 4 Oct 2022 04:05:46 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E8B3A1BE9C for ; Tue, 4 Oct 2022 01:05:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1664870743; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uMu76vQvIVy0lO6nNZVWjFAp1YNB5+RujDkPLYpaS9Q=; b=X0iVCiwaj+hR/kPqHGQBWgWAI83KxkjAfdEp7QxdoXKno/VQg7IiBTLivoWuH+ww/21AeZ zJZauc/Afb3V/IuabX9RUtovjABjNRZGR+MTDsaprvtFOdkQupfXho5r1kj9JOSlu4MBRn tOSVzQj9QXzlXWsetzYiPp/fXtjBNN8= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-659-AZlv-s8jO5uDnuupALKBBw-1; Tue, 04 Oct 2022 04:05:39 -0400 X-MC-Unique: AZlv-s8jO5uDnuupALKBBw-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 540FB299E751; Tue, 4 Oct 2022 08:05:39 +0000 (UTC) Received: from redhat.com (unknown [10.33.36.5]) by smtp.corp.redhat.com (Postfix) with ESMTPS id F0A2A17583; Tue, 4 Oct 2022 08:05:37 +0000 (UTC) Date: Tue, 4 Oct 2022 09:05:35 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Cc: "Jason A. Donenfeld" , qemu-devel@nongnu.org, Jiaxun Yang , Aurelien Jarno , kvm-devel , Laurent Vivier Subject: Re: [PATCH v2] mips/malta: pass RNG seed to to kernel via env var Message-ID: Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= References: <20221003103627.947985-1-Jason@zx2c4.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/2.2.7 (2022-08-07) X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Tue, Oct 04, 2022 at 12:36:03AM +0200, Philippe Mathieu-Daudé wrote: > Hi Jason, > > Per https://www.qemu.org/docs/master/devel/submitting-a-patch.html#when-resending-patches-add-a-version-tag: > > Send each new revision as a new top-level thread, rather than burying it > in-reply-to an earlier revision, as many reviewers are not looking inside > deep threads for new patches. > > On 3/10/22 12:36, Jason A. Donenfeld wrote: > > As of the kernel commit linked below, Linux ingests an RNG seed > > passed from the hypervisor. So, pass this for the Malta platform, and > > reinitialize it on reboot too, so that it's always fresh. > > > > Cc: Philippe Mathieu-Daudé > > Cc: Jiaxun Yang > > Cc: Aurelien Jarno > > Link: https://git.kernel.org/mips/c/056a68cea01 > > You seem to justify this commit by the kernel commit, which justifies > itself mentioning hypervisor use... So the egg comes first before the > chicken. The kernel justification is that the guest OS needs a good RNG seed. The kernel patch is just saying that the firmware / hypervisor side is where this seed generally expected to come from. This is fine, and not notably different from what Jason's already got wired up for the various other targets in QEMU. With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|