public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Oliver Upton <oliver.upton@linux.dev>
To: Alexandru Elisei <alexandru.elisei@arm.com>
Cc: kvmarm@lists.linux.dev, kvm@vger.kernel.org,
	Will Deacon <will@kernel.org>,
	Julien Thierry <julien.thierry.kdev@gmail.com>
Subject: Re: [RFC kvmtool 9/9] arm64: Get rid of the 'arm-common' include directory
Date: Tue, 25 Mar 2025 10:02:24 -0700	[thread overview]
Message-ID: <Z-LhoOxnQ9xpqL-Q@linux.dev> (raw)
In-Reply-To: <Z9xJ10c4pwJ-TF3o@raptor>

Hi Alex,

On Thu, Mar 20, 2025 at 05:01:11PM +0000, Alexandru Elisei wrote:
> Hi Oliver,
> 
> On Fri, Mar 14, 2025 at 03:25:16PM -0700, Oliver Upton wrote:
> > Signed-off-by: Oliver Upton <oliver.upton@linux.dev>
> > ---
> >  arm64/arm-cpu.c                        | 4 ++--
> >  arm64/fdt.c                            | 4 ++--
> >  arm64/gic.c                            | 2 +-
> >  arm64/gicv2m.c                         | 2 +-
> >  arm64/include/{arm-common => }/gic.h   | 0
> >  arm64/include/kvm/kvm-arch.h           | 2 +-
> >  arm64/include/{arm-common => }/pci.h   | 0
> >  arm64/include/{arm-common => }/timer.h | 0
> 
> Looking at x86 and riscv, the pattern is to have the header files in
> <arch>/include/kvm, even if they're only used by the arch code.
> 
> Do we care about following this pattern?

I have no strong preference in either direction, I just did the laziest
thing here.

Thanks,
Oliver

  reply	other threads:[~2025-03-25 17:02 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-14 22:25 [RFC kvmtool 0/9] arm: Drop support for 32-bit kvmtool Oliver Upton
2025-03-14 22:25 ` [RFC kvmtool 1/9] Drop support for 32-bit arm Oliver Upton
2025-03-20 16:58   ` Alexandru Elisei
2025-03-25 17:08     ` Oliver Upton
2025-03-14 22:25 ` [RFC kvmtool 2/9] arm64: Move arm64-only features into main directory Oliver Upton
2025-03-14 22:25 ` [RFC kvmtool 3/9] arm64: Combine kvm.c Oliver Upton
2025-03-20 16:59   ` Alexandru Elisei
2025-03-14 22:25 ` [RFC kvmtool 4/9] arm64: Merge kvm-cpu.c Oliver Upton
2025-03-14 22:25 ` [RFC kvmtool 5/9] arm64: Combine kvm-config-arch.h Oliver Upton
2025-03-14 22:25 ` [RFC kvmtool 6/9] arm64: Move remaining kvm/* headers Oliver Upton
2025-03-14 22:25 ` [RFC kvmtool 7/9] arm64: Move asm headers Oliver Upton
2025-03-14 22:25 ` [RFC kvmtool 8/9] arm64: Rename top-level directory Oliver Upton
2025-03-14 22:25 ` [RFC kvmtool 9/9] arm64: Get rid of the 'arm-common' include directory Oliver Upton
2025-03-20 17:01   ` Alexandru Elisei
2025-03-25 17:02     ` Oliver Upton [this message]
2025-03-17 10:39 ` [RFC kvmtool 0/9] arm: Drop support for 32-bit kvmtool Alexandru Elisei
2025-03-17 10:51   ` Marc Zyngier
2025-03-18  1:10     ` Oliver Upton
2025-03-19 14:18   ` Andre Przywara
2025-03-17 11:14 ` Marc Zyngier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z-LhoOxnQ9xpqL-Q@linux.dev \
    --to=oliver.upton@linux.dev \
    --cc=alexandru.elisei@arm.com \
    --cc=julien.thierry.kdev@gmail.com \
    --cc=kvm@vger.kernel.org \
    --cc=kvmarm@lists.linux.dev \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox