From: Sean Christopherson <seanjc@google.com>
To: Yosry Ahmed <yosry.ahmed@linux.dev>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Jim Mattson <jmattson@google.com>,
x86@kernel.org, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] KVM: x86: Unify cross-vCPU IBPB
Date: Wed, 26 Mar 2025 15:42:00 -0700 [thread overview]
Message-ID: <Z-SCuESxIaOR0bCw@google.com> (raw)
In-Reply-To: <Z-R8xRbsjv4lalAX@google.com>
On Wed, Mar 26, 2025, Yosry Ahmed wrote:
> On Wed, Mar 26, 2025 at 01:46:04PM -0700, Sean Christopherson wrote:
> > > @@ -12367,10 +12381,13 @@ void kvm_arch_vcpu_postcreate(struct kvm_vcpu *vcpu)
> > >
> > > void kvm_arch_vcpu_destroy(struct kvm_vcpu *vcpu)
> > > {
> > > - int idx;
> > > + int idx, cpu;
> > >
> > > kvmclock_reset(vcpu);
> > >
> > > + for_each_possible_cpu(cpu)
> > > + cmpxchg(per_cpu_ptr(&last_vcpu, cpu), vcpu, NULL);
> >
> > It's definitely worth keeping a version of SVM's comment to explaining the cross-CPU
> > nullification.
>
> Good idea. Should I send a new version or will you take care of this as
> well while applying?
I'll fixup when applying.
next prev parent reply other threads:[~2025-03-26 22:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-20 1:37 [PATCH] KVM: x86: Unify cross-vCPU IBPB Yosry Ahmed
2025-03-26 20:46 ` Sean Christopherson
2025-03-26 22:16 ` Yosry Ahmed
2025-03-26 22:42 ` Sean Christopherson [this message]
2025-05-02 21:50 ` Sean Christopherson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z-SCuESxIaOR0bCw@google.com \
--to=seanjc@google.com \
--cc=jmattson@google.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=x86@kernel.org \
--cc=yosry.ahmed@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox