From: Bernhard Kauer <bk@alpico.io>
To: Marc Zyngier <maz@kernel.org>
Cc: Bernhard Kauer <bk@alpico.io>,
Paolo Bonzini <pbonzini@redhat.com>,
kvm@vger.kernel.org
Subject: Re: [PATCH v2] KVM: make uevents configurable
Date: Mon, 2 Dec 2024 12:07:23 +0100 [thread overview]
Message-ID: <Z02U64ebpuvFGnhe@mias.mediconcil.de> (raw)
In-Reply-To: <86wmgitlkv.wl-maz@kernel.org>
On Mon, Dec 02, 2024 at 10:40:00AM +0000, Marc Zyngier wrote:
> > +bool disable_uevent_notify;
>
> static?
Yes.
> <bikeshed-time>
> I'd rather have a positive logic. Something like:
>
> +static bool uevent_notify = true;
> +module_param(uevent_notify, bool, 0644);
Choosing readability vs one byte in the data-section seems to be a good
tradeoff.
> </bikeshed-time>
>
> I would also expect some form of documentation in
> Documentation/admin-guide/kernel-parameters.txt.
Good point. I will add this in v3.
Thanks,
Bernhard
prev parent reply other threads:[~2024-12-02 11:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-02 9:06 [PATCH v2] KVM: make uevents configurable Bernhard Kauer
2024-12-02 10:40 ` Marc Zyngier
2024-12-02 11:07 ` Bernhard Kauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z02U64ebpuvFGnhe@mias.mediconcil.de \
--to=bk@alpico.io \
--cc=kvm@vger.kernel.org \
--cc=maz@kernel.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox