Re: [PATCH 06/15] KVM: SVM: Disable intercepts for all direct access MSRs on MSR filter changes

[Sean Christopherson <seanjc@google.com>]

On Wed, Nov 27, 2024, Aaron Lewis wrote:
> From: Anish Ghulati <aghulati@google.com>
> 
> For all direct access MSRs, disable the MSR interception explicitly.
> svm_disable_intercept_for_msr() checks the new MSR filter and ensures that
> KVM enables interception if userspace wants to filter the MSR.
> 
> This change is similar to the VMX change:
>   d895f28ed6da ("KVM: VMX: Skip filter updates for MSRs that KVM is already intercepting")
> 
> Adopting in SVM to align the implementations.

Wording and mood are all funky.

  Give SVM the same treatment as was given VMX in commit d895f28ed6da ("KVM:
  VMX: Skip filter updates for MSRs that KVM is already intercepting"), and
  explicitly disable MSR interception when reacting to an MSR filter change.
  There is no need to change anything for MSRs KVM is already intercepting,
  and svm_disable_intercept_for_msr() performs the necessary filter checks.

> 
> Suggested-by: Sean Christopherson <seanjc@google.com>
> Co-developed-by: Aaron Lewis <aaronlewis@google.com>
> Signed-off-by: Anish Ghulati <aghulati@google.com>

See the docs again.  The order is wrong, and your SoB is missing.