From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Arnd Bergmann <arnd@kernel.org>,
linux-kernel@vger.kernel.org, x86@kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
"H. Peter Anvin" <hpa@zytor.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Matthew Wilcox <willy@infradead.org>,
Sean Christopherson <seanjc@google.com>,
Davide Ciminaghi <ciminaghi@gnudd.com>,
Paolo Bonzini <pbonzini@redhat.com>,
kvm@vger.kernel.org
Subject: Re: [PATCH 06/11] x86: drop SWIOTLB and PHYS_ADDR_T_64BIT for PAE
Date: Thu, 5 Dec 2024 09:59:21 +0200 [thread overview]
Message-ID: <Z1FdWZHa79OH2b9F@smile.fi.intel.com> (raw)
In-Reply-To: <d84fc2e4-ca81-42b1-ae44-292d0b32c7ed@app.fastmail.com>
On Wed, Dec 04, 2024 at 09:52:01PM +0100, Arnd Bergmann wrote:
> On Wed, Dec 4, 2024, at 19:41, Andy Shevchenko wrote:
> > On Wed, Dec 4, 2024 at 12:31 PM Arnd Bergmann <arnd@kernel.org> wrote:
...
> >> pr_warn_once("%s: Cannot satisfy [mem %#010llx-%#010llx] with a huge-page mapping due to MTRR override.\n",
> >> - __func__, addr, addr + PMD_SIZE);
> >> + __func__, (u64)addr, (u64)addr + PMD_SIZE);
> >
> > Instead of castings I would rather:
> > 1) have addr and size (? does above have off-by-one error?) or end;
> > 2) use struct resource / range with the respective %p[Rr][a] specifier
> > or use %pa.
>
> Changed as below now. I'm still not sure whether the mtrr_type_lookup
> end argument is meant to be inclusive or exclusive, so I've left
> that alone, but the printed range should be correct now.
Yep, thanks!
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-12-05 7:59 UTC|newest]
Thread overview: 77+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-04 10:30 [PATCH 00/11] x86: 32-bit cleanups Arnd Bergmann
2024-12-04 10:30 ` [PATCH 01/11] x86/Kconfig: Geode CPU has cmpxchg8b Arnd Bergmann
2024-12-04 10:30 ` [PATCH 02/11] x86: drop 32-bit "bigsmp" machine support Arnd Bergmann
2024-12-04 10:30 ` [PATCH 03/11] x86: Kconfig.cpu: split out 64-bit atom Arnd Bergmann
2024-12-04 13:16 ` Thomas Gleixner
2024-12-04 15:55 ` H. Peter Anvin
2024-12-04 18:21 ` Andy Shevchenko
2024-12-04 10:30 ` [PATCH 04/11] x86: split CPU selection into 32-bit and 64-bit Arnd Bergmann
2024-12-04 18:31 ` Andy Shevchenko
2024-12-04 21:18 ` Arnd Bergmann
2024-12-04 10:30 ` [PATCH 05/11] x86: remove HIGHMEM64G support Arnd Bergmann
2024-12-04 13:29 ` Brian Gerst
2024-12-04 13:43 ` Arnd Bergmann
2024-12-04 14:02 ` Brian Gerst
2024-12-04 15:00 ` Brian Gerst
2024-12-04 15:58 ` H. Peter Anvin
2024-12-04 15:53 ` H. Peter Anvin
2024-12-04 16:37 ` H. Peter Anvin
2024-12-04 16:55 ` Arnd Bergmann
2024-12-04 18:37 ` Andy Shevchenko
2024-12-04 21:14 ` Arnd Bergmann
2025-04-11 23:44 ` Dave Hansen
2025-04-12 8:39 ` Ingo Molnar
2025-04-12 10:05 ` Mike Rapoport
2025-04-12 10:44 ` Arnd Bergmann
2025-04-12 19:48 ` Ingo Molnar
2025-04-13 8:08 ` [PATCH] x86/e820: discard high memory that can't be addressed by 32-bit systems Mike Rapoport
2025-04-13 9:23 ` [tip: x86/urgent] x86/e820: Discard " tip-bot2 for Mike Rapoport (Microsoft)
2025-04-14 14:19 ` Dave Hansen
2025-04-15 7:18 ` Mike Rapoport
2025-04-15 13:43 ` Dave Hansen
2025-04-16 7:17 ` Ingo Molnar
2025-04-16 7:51 ` Ingo Molnar
2025-04-16 7:24 ` tip-bot2 for Mike Rapoport (Microsoft)
2025-04-16 8:16 ` tip-bot2 for Mike Rapoport (Microsoft)
2025-04-17 16:22 ` [PATCH] x86/e820: discard " Nathan Chancellor
2025-04-18 6:33 ` Ingo Molnar
2025-04-18 9:01 ` Mike Rapoport
2025-04-18 12:59 ` Ingo Molnar
2025-04-18 19:25 ` Mike Rapoport
2025-04-18 19:29 ` Dave Hansen
2025-04-18 19:49 ` Guenter Roeck
2025-04-12 10:40 ` [PATCH 05/11] x86: remove HIGHMEM64G support Arnd Bergmann
2024-12-04 10:30 ` [PATCH 06/11] x86: drop SWIOTLB and PHYS_ADDR_T_64BIT for PAE Arnd Bergmann
2024-12-04 18:41 ` Andy Shevchenko
2024-12-04 20:52 ` Arnd Bergmann
2024-12-05 7:59 ` Andy Shevchenko [this message]
2024-12-04 10:30 ` [PATCH 07/11] x86: drop support for CONFIG_HIGHPTE Arnd Bergmann
2024-12-04 10:30 ` [PATCH 08/11] x86: document X86_INTEL_MID as 64-bit-only Arnd Bergmann
2024-12-04 18:55 ` Andy Shevchenko
2024-12-04 20:38 ` Arnd Bergmann
2024-12-05 8:03 ` Andy Shevchenko
2024-12-06 11:23 ` Ferry Toth
2024-12-06 14:27 ` Arnd Bergmann
2024-12-04 10:30 ` [PATCH 09/11] x86: rework CONFIG_GENERIC_CPU compiler flags Arnd Bergmann
2024-12-04 15:36 ` Tor Vic
2024-12-04 17:51 ` Arnd Bergmann
2024-12-04 17:09 ` Nathan Chancellor
2024-12-04 17:52 ` Arnd Bergmann
2024-12-04 18:10 ` Linus Torvalds
2024-12-04 19:43 ` Arnd Bergmann
2024-12-04 23:33 ` Linus Torvalds
2024-12-05 8:13 ` Andy Shevchenko
2024-12-05 10:09 ` Arnd Bergmann
2024-12-05 11:17 ` Andy Shevchenko
2024-12-05 11:58 ` Arnd Bergmann
2024-12-05 12:35 ` Jason A. Donenfeld
2024-12-05 9:46 ` Arnd Bergmann
2024-12-05 10:01 ` Andy Shevchenko
2024-12-05 10:47 ` Arnd Bergmann
2024-12-05 8:07 ` Andy Shevchenko
2024-12-06 13:56 ` David Laight
2024-12-04 10:30 ` [PATCH 10/11] x86: remove old STA2x11 support Arnd Bergmann
2024-12-05 7:35 ` Davide Ciminaghi
2024-12-04 10:30 ` [PATCH 11/11] x86: drop 32-bit KVM host support Arnd Bergmann
2024-12-04 15:30 ` Sean Christopherson
2024-12-04 16:33 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z1FdWZHa79OH2b9F@smile.fi.intel.com \
--to=andy.shevchenko@gmail.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=bp@alien8.de \
--cc=ciminaghi@gnudd.com \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=seanjc@google.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=willy@infradead.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).