public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Sean Christopherson <seanjc@google.com>
To: Borislav Petkov <bp@alien8.de>
Cc: Aaron Lewis <aaronlewis@google.com>,
	kvm@vger.kernel.org, pbonzini@redhat.com,  jmattson@google.com,
	Xin Li <xin@zytor.com>, Dapeng Mi <dapeng1.mi@linux.intel.com>
Subject: Re: [PATCH 12/15] KVM: x86: Track possible passthrough MSRs in kvm_x86_ops
Date: Fri, 6 Dec 2024 07:23:43 -0800	[thread overview]
Message-ID: <Z1MW__KcGo-QyDtc@google.com> (raw)
In-Reply-To: <20241205180608.GCZ1HrkLq2NQfpNoy-@fat_crate.local>

On Thu, Dec 05, 2024, Borislav Petkov wrote:
> On Tue, Dec 03, 2024 at 11:47:33AM -0800, Sean Christopherson wrote:
> > It applies cleanly on my tree (github.com/kvm-x86/linux.git next)
> 
> Could it be that you changed things in the meantime?

Nope, I double checked that I'm using the same base.
 
> (Very similar result on Paolo's next branch.)
> 
> $ git log -1
> commit c55f6b8a2441b20ef12e4b35d4888a22299ddc90 (HEAD -> refs/heads/kvm-next, tag: refs/tags/kvm-x86-next-2024.11.04, refs/remotes/kvm-x86/next)
> Merge: f29af315c943 bc17fccb37c8
> Author: Sean Christopherson <seanjc@google.com>
> Date:   Tue Nov 5 05:13:01 2024 +0000
> 
>     Merge branch 'vmx'
>     
>     * vmx:
>       KVM: VMX: Remove the unused variable "gpa" in __invept()
> 
> 
> $ patch -p1 --dry-run -i /tmp/0001-tmp.patch 
> checking file arch/x86/include/asm/kvm-x86-ops.h
> checking file arch/x86/include/asm/kvm_host.h

Are you trying to apply this patch directly on kvm/next | kvm-x86/next?  This is
patch 12 of 15.

> Hunk #1 succeeded at 1817 (offset -2 lines).
> checking file arch/x86/kvm/lapic.h
> checking file arch/x86/kvm/svm/svm.c
> Reversed (or previously applied) patch detected!  Assume -R? [n] n
> Apply anyway? [n] y
> Hunk #1 FAILED at 79.
> Hunk #2 FAILED at 756.
> Hunk #3 FAILED at 831.
> Hunk #4 FAILED at 870.
> Hunk #5 FAILED at 907.
> Hunk #6 succeeded at 894 with fuzz 1 (offset -30 lines).
> Hunk #7 FAILED at 1002.
> Hunk #8 FAILED at 1020.
> Hunk #9 FAILED at 1103.
> Hunk #10 FAILED at 1121.
> Hunk #11 FAILED at 1309.
> Hunk #12 FAILED at 1330.
> Hunk #13 FAILED at 1456.
> Hunk #14 succeeded at 1455 (offset -35 lines).
> Hunk #15 succeeded at 1479 (offset -35 lines).
> Hunk #16 FAILED at 1555.
> Hunk #17 succeeded at 3220 (offset -40 lines).
> Hunk #18 FAILED at 4531.
> Hunk #19 succeeded at 5194 (offset -38 lines).
> Hunk #20 succeeded at 5352 (offset -38 lines).
> 14 out of 20 hunks FAILED
> checking file arch/x86/kvm/svm/svm.h
> checking file arch/x86/kvm/vmx/main.c
> checking file arch/x86/kvm/vmx/vmx.c
> Hunk #2 succeeded at 642 (offset -2 lines).
> Hunk #3 FAILED at 3943.
> Hunk #4 FAILED at 3985.
> Hunk #5 succeeded at 4086 (offset -1 lines).
> Hunk #6 succeeded at 7532 (offset 6 lines).
> Hunk #7 succeeded at 7812 (offset 6 lines).
> Hunk #8 succeeded at 7827 (offset 6 lines).
> 2 out of 8 hunks FAILED
> checking file arch/x86/kvm/vmx/vmx.h
> checking file arch/x86/kvm/vmx/x86_ops.h
> checking file arch/x86/kvm/x86.c
> Hunk #1 succeeded at 10837 (offset -3 lines).
> 
> -- 
> Regards/Gruss,
>     Boris.
> 
> https://people.kernel.org/tglx/notes-about-netiquette

  reply	other threads:[~2024-12-06 15:23 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-27 20:19 [PATCH 00/15] Unify MSR intercepts in x86 Aaron Lewis
2024-11-27 20:19 ` [PATCH 01/15] KVM: x86: Use non-atomic bit ops to manipulate "shadow" MSR intercepts Aaron Lewis
2024-11-27 20:38   ` Sean Christopherson
2024-11-27 20:19 ` [PATCH 02/15] KVM: SVM: Use non-atomic bit ops to manipulate MSR interception bitmaps Aaron Lewis
2024-11-27 20:19 ` [PATCH 03/15] KVM: SVM: Invert the polarity of the "shadow" " Aaron Lewis
2024-11-27 20:42   ` Sean Christopherson
2024-12-03 21:08     ` Tom Lendacky
2024-11-27 20:19 ` [PATCH 04/15] KVM: SVM: Track MSRPM as "unsigned long", not "u32" Aaron Lewis
2024-11-27 20:19 ` [PATCH 05/15] KVM: x86: SVM: Adopt VMX style MSR intercepts in SVM Aaron Lewis
2024-11-27 20:43   ` Sean Christopherson
2024-11-27 20:19 ` [PATCH 06/15] KVM: SVM: Disable intercepts for all direct access MSRs on MSR filter changes Aaron Lewis
2024-11-27 20:47   ` Sean Christopherson
2024-11-27 20:19 ` [PATCH 07/15] KVM: SVM: Delete old SVM MSR management code Aaron Lewis
2024-11-27 20:19 ` [PATCH 08/15] KVM: SVM: Pass through GHCB MSR if and only if VM is SEV-ES Aaron Lewis
2024-12-03 21:21   ` Tom Lendacky
2024-11-27 20:19 ` [PATCH 09/15] KVM: SVM: Drop "always" flag from list of possible passthrough MSRs Aaron Lewis
2024-12-03 21:26   ` Tom Lendacky
2024-11-27 20:19 ` [PATCH 10/15] KVM: SVM: Don't "NULL terminate" the " Aaron Lewis
2024-12-03 21:30   ` Tom Lendacky
2024-11-27 20:19 ` [PATCH 11/15] KVM: VMX: Make list of possible passthrough MSRs "const" Aaron Lewis
2024-11-27 20:19 ` [PATCH 12/15] KVM: x86: Track possible passthrough MSRs in kvm_x86_ops Aaron Lewis
2024-11-27 21:57   ` Sean Christopherson
2024-11-28 16:46     ` Borislav Petkov
2024-12-03 19:47       ` Sean Christopherson
2024-12-05 17:56         ` Borislav Petkov
2024-12-05 18:06         ` Borislav Petkov
2024-12-06 15:23           ` Sean Christopherson [this message]
2024-12-06 16:01             ` Borislav Petkov
2024-11-27 20:19 ` [PATCH 13/15] KVM: x86: Move ownership of passthrough MSR "shadow" to common x86 Aaron Lewis
2024-11-27 20:19 ` [PATCH 14/15] KVM: x86: Hoist SVM MSR intercepts to common x86 code Aaron Lewis
2024-11-27 20:19 ` [PATCH 15/15] KVM: x86: Hoist VMX " Aaron Lewis
2024-11-27 20:56 ` [PATCH 00/15] Unify MSR intercepts in x86 Sean Christopherson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z1MW__KcGo-QyDtc@google.com \
    --to=seanjc@google.com \
    --cc=aaronlewis@google.com \
    --cc=bp@alien8.de \
    --cc=dapeng1.mi@linux.intel.com \
    --cc=jmattson@google.com \
    --cc=kvm@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=xin@zytor.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox