public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Sean Christopherson <seanjc@google.com>
To: Josh Poimboeuf <jpoimboe@kernel.org>
Cc: Nathan Chancellor <nathan@kernel.org>,
	Borislav Petkov <bp@alien8.de>,
	x86@kernel.org,  Kim Phillips <kim.phillips@amd.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	linux-kernel@vger.kernel.org,  kvm@vger.kernel.org
Subject: Re: Hitting AUTOIBRS WARN_ON_ONCE() in init_amd() booting 32-bit kernel under KVM
Date: Mon, 9 Dec 2024 12:54:24 -0800	[thread overview]
Message-ID: <Z1dZAD4_kgmm-B-_@google.com> (raw)
In-Reply-To: <20241209204414.psmh3yyllnwbrc4y@jpoimboe>

On Mon, Dec 09, 2024, Josh Poimboeuf wrote:
> On Fri, Dec 06, 2024 at 08:20:06AM -0800, Sean Christopherson wrote:
> > From: Sean Christopherson <seanjc@google.com>
> > Date: Fri, 6 Dec 2024 08:14:45 -0800
> > Subject: [PATCH] x86/CPU/AMD: WARN when setting EFER.AUTOIBRS if and only if
> >  the WRMSR fails
> > 
> > When ensuring EFER.AUTOIBRS is set, WARN only on a negative return code
> > from msr_set_bit(), as '1' is used to indicate the WRMSR was successful
> > ('0' indicates the MSR bit was already set).
> > 
> > Fixes: 8cc68c9c9e92 ("x86/CPU/AMD: Make sure EFER[AIBRSE] is set")
> > Reported-by: Nathan Chancellor <nathan@kernel.org>
> > Closes: https://lore.kernel.org/all/20241205220604.GA2054199@thelio-3990X
> > Signed-off-by: Sean Christopherson <seanjc@google.com>
> 
> LGTM, but please post as a proper patch in its own thread so the -tip
> maintainers are more likely to see it.

In Boris I trust :-)

Already in Linus' tree, commit 492077668fb4 ("x86/CPU/AMD: WARN when setting
EFER.AUTOIBRS if and only if the WRMSR fails").

  reply	other threads:[~2024-12-09 20:54 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-05 22:06 Hitting AUTOIBRS WARN_ON_ONCE() in init_amd() booting 32-bit kernel under KVM Nathan Chancellor
2024-12-06 16:20 ` Sean Christopherson
2024-12-09 20:44   ` Josh Poimboeuf
2024-12-09 20:54     ` Sean Christopherson [this message]
2024-12-09 20:59       ` Borislav Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z1dZAD4_kgmm-B-_@google.com \
    --to=seanjc@google.com \
    --cc=bp@alien8.de \
    --cc=jpoimboe@kernel.org \
    --cc=kim.phillips@amd.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nathan@kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox