Re: [PATCH v2 1/2] net: mana: Fix memory leak in mana_gd_setup_irqs

Kalesh Anakkur Purayil
2024-12-10T08:05:53Z

[-- Attachment #1: Type: text/plain, Size: 552 bytes --]

On Mon, Dec 9, 2024 at 11:28 PM Maxim Levitsky <mlevitsk@redhat.com> wrote:
>
> Commit 8afefc361209 ("net: mana: Assigning IRQ affinity on HT cores")
> added memory allocation in mana_gd_setup_irqs of 'irqs' but the code
> doesn't free this temporary array in the success path.
>
> This was caught by kmemleak.
>
> Fixes: 8afefc361209 ("net: mana: Assigning IRQ affinity on HT cores")
> Signed-off-by: Maxim Levitsky <mlevitsk@redhat.com>

LGTM
Reviewed-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>

--
Regards,
Kalesh A P

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4239 bytes --]