From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-184.mta0.migadu.com (out-184.mta0.migadu.com [91.218.175.184]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ECEFB1F8F03 for ; Tue, 17 Dec 2024 18:01:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.184 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734458466; cv=none; b=ZZwQRLqmE1aevy6gpgR6Nb7KocbCDq+Q6LhvvEEQ0U4Urq/ny2r7ch6K0MBkfbvIHVoUZCY0vlQXOTY3u/COsYgQL3Mt6MvmtkoPeevh5twWzf1ZaIdYbUWW9Qnx2Z47a5D2JXLjNl2H6nYjm6bzOwg39FSl54Rc7wIJ07Qb51k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734458466; c=relaxed/simple; bh=jqkqto/wE4TTKCgi/7/Xdmt2B/vG2gmyRNK4LWWebrI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=pGaxbDPrFzMYXyialwdyaPBeuv5DLcrDGYSHTTE2F1wc6o0U4s3sXPNiSfP+HBUa7Si5ryzzAWQ7c0Mm13K1NXwvtHwalg7R073QQyoS2wbBpFCrTvOtVPpz5I6zcukTQ7UIorxKg48YhYXBIftmpohADAc4DxajXXiIqRt+w6M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=o1alYDL5; arc=none smtp.client-ip=91.218.175.184 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="o1alYDL5" Date: Tue, 17 Dec 2024 10:00:44 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1734458457; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=PkRrOqmYm8mFGf6ZziFnsHC8gAVb4/Jvhm1aIGMdXpg=; b=o1alYDL5oQ4U8aVIN4LJhtvgi4JR5Ey49e8Jt93GpKesUTx0JkYkIFh8FnbUMROwIWNZg6 lZMsN6urvrxNfEWq3T+ly+eCv55DhHRMSKihuA66VsYN0xym5XSDu1/PWs39zrbZDmKbEN P8Tu9j/uueBx7LvvaEsb2L1rCH8Fhq0= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Oliver Upton To: Mark Brown Cc: Marc Zyngier , Joey Gouly , Suzuki K Poulose , Paolo Bonzini , Shuah Khan , Catalin Marinas , Zenghui Yu , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, kvm@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] KVM: arm64: Fix set_id_regs selftest for ASIDBITS becoming unwritable Message-ID: References: <20241216-kvm-arm64-fix-set-id-asidbits-v1-1-8b105b888fc3@kernel.org> <875xnisocy.wl-maz@kernel.org> <53b40aa8-f51c-4c4e-a4ad-e6a9512e5197@sirena.org.uk> <86v7viqusg.wl-maz@kernel.org> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT On Tue, Dec 17, 2024 at 03:10:28PM +0000, Mark Brown wrote: > On Tue, Dec 17, 2024 at 01:54:39PM +0000, Marc Zyngier wrote: > > Mark Brown wrote: > > > > The selftests are shipped as part of the kernel source and frequently > > > used for testing the kernel, it's all one source base and we want to > > > ensure that for example the test fix gets backported if the relevant > > > kernel patch does. > > > That's not what Fixes: describes. If you want to invent a new tag that > > expresses a dependency, do that. Don't use these tags to misrepresent > > what the patches does. > > No, this isn't a new use - a Fixes: tag indicates that the referenced > commit introduced the problem being fixed and that is exactly what's > going on here. Like I say the selftests are not a completely separate > project, they are a part of the same source release as the rest of the > kernel and it is helpful to track information like this. A Fixes tag suggests a bug in the referenced commit, which isn't the case here. I agree that having some relation between the two is useful for determining the scope of a backport, but conveniently in this case the test failure was introduced in 6.13. I've taken the fix for 6.13, w/ the tag dropped. -- Thanks, Oliver