Re: [PATCH v5 01/11 for v9.2?] i386/cpu: Mark avx10_version filtered when prefix is NULL

Michael Tokarev
2024-12-20T21:13:56Z

06.11.2024 06:07, Zhao Liu wrote:
> In x86_cpu_filter_features(), if host doesn't support AVX10, the
> configured avx10_version should be marked as filtered regardless of
> whether prefix is NULL or not.
>
> Check prefix before warn_report() instead of checking for
> have_filtered_features.
>
> Cc: qemu-stable@nongnu.org
> Fixes: commit bccfb846fd52 ("target/i386: add AVX10 feature and AVX10 version property")
> Signed-off-by: Zhao Liu <zhao1.liu@intel.com>

Hi!

Has this patch been forgotten? 9.2 is out already and I'm collecting fixes for it...

Thanks,

/mjt

> ---
> v5: new commit.
> ---
> target/i386/cpu.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/target/i386/cpu.c b/target/i386/cpu.c
> index 3baa95481fbc..77c1233daa13 100644
> --- a/target/i386/cpu.c
> +++ b/target/i386/cpu.c
> @@ -7711,8 +7711,10 @@ static bool x86_cpu_filter_features(X86CPU *cpu, bool verbose)
> env->avx10_version = version;
> have_filtered_features = true;
> }
> - } else if (env->avx10_version && prefix) {
> - warn_report("%s: avx10.%d.", prefix, env->avx10_version);
> + } else if (env->avx10_version) {
> + if (prefix) {
> + warn_report("%s: avx10.%d.", prefix, env->avx10_version);
> + }
> have_filtered_features = true;
> }
>

--
GPG Key transition (from rsa2048 to rsa4096) since 2024-04-24.
New key: rsa4096/61AD3D98ECDF2C8E 9D8B E14E 3F2A 9DD7 9199 28F1 61AD 3D98 ECDF 2C8E
Old key: rsa2048/457CE0A0804465C5 6EE1 95D1 886E 8FFB 810D 4324 457C E0A0 8044 65C5
Transition statement: http://www.corpit.ru/mjt/gpg-transition-2024.txt