Re: [PATCH v5 04/11] target/i386/kvm: Only save/load kvmclock MSRs when kvmclock enabled

Paolo Bonzini
2024-12-24T15:31:35Z

On 11/6/24 04:07, Zhao Liu wrote:
> MSR_KVM_SYSTEM_TIME and MSR_KVM_WALL_CLOCK are attached with the (old)
> kvmclock feature (KVM_FEATURE_CLOCKSOURCE).
>
> So, just save/load them only when kvmclock (KVM_FEATURE_CLOCKSOURCE) is
> enabled.
>
> Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
>

The MSRs contains the same values as the "new" pair; QEMU only has to
save/restore one of them but the code should be active for both feature
bits and thus use

+ if (env->env.features[FEAT_KVM] & (CPUID_KVM_CLOCK |
+ CPUID_KVM_CLOCK2)) {

Paolo