From: Sean Christopherson <seanjc@google.com>
To: Suleiman Souhlal <suleiman@google.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
Chao Gao <chao.gao@intel.com>,
David Woodhouse <dwmw2@infradead.org>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
ssouhlal@freebsd.org
Subject: Re: [PATCH v3 3/3] KVM: x86: Document host suspend being included in steal time.
Date: Tue, 7 Jan 2025 07:37:54 -0800 [thread overview]
Message-ID: <Z31KUrNvDxqyEBsn@google.com> (raw)
In-Reply-To: <20250107042202.2554063-4-suleiman@google.com>
On Tue, Jan 07, 2025, Suleiman Souhlal wrote:
> Steal time now includes the time that the host was suspended.
>
> Change-Id: Ie1236bc787e0d3bc9aff0d35e6b82b7e5cc8fd91
gerrit.
> Signed-off-by: Suleiman Souhlal <suleiman@google.com>
> ---
> Documentation/virt/kvm/x86/msr.rst | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/virt/kvm/x86/msr.rst b/Documentation/virt/kvm/x86/msr.rst
> index 3aecf2a70e7b43..81c17c2200ca2f 100644
> --- a/Documentation/virt/kvm/x86/msr.rst
> +++ b/Documentation/virt/kvm/x86/msr.rst
> @@ -294,8 +294,10 @@ data:
>
> steal:
> the amount of time in which this vCPU did not run, in
> - nanoseconds. Time during which the vcpu is idle, will not be
> - reported as steal time.
> + nanoseconds. This includes the time during which the host is
> + suspended. However, the case where the host suspends during a
> + VM migration might not be correctly accounted. Time during
> + which the vcpu is idle, will not be reported as steal time.
This belongs in the previous patch. All in all, IMO this can all be one single
patch, as I don't see any reason to put crud into common KVM.
>
> preempted:
> indicate the vCPU who owns this struct is running or
> --
> 2.47.1.613.gc27f4b7a9f-goog
>
prev parent reply other threads:[~2025-01-07 15:37 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-07 4:21 [PATCH v3 0/3] KVM: x86: Include host suspended time in steal time Suleiman Souhlal
2025-01-07 4:21 ` [PATCH v3 1/3] kvm: Introduce kvm_total_suspend_ns() Suleiman Souhlal
2025-01-07 15:27 ` Sean Christopherson
2025-01-07 16:43 ` Suleiman Souhlal
2025-01-08 7:15 ` kernel test robot
2025-01-08 8:36 ` kernel test robot
2025-01-15 21:49 ` Sean Christopherson
2025-01-17 6:35 ` Suleiman Souhlal
2025-01-17 16:52 ` Sean Christopherson
2025-01-21 5:37 ` Suleiman Souhlal
2025-01-21 20:22 ` Sean Christopherson
2025-02-04 7:58 ` Suleiman Souhlal
2025-02-05 5:55 ` Suleiman Souhlal
2025-02-06 1:29 ` Sean Christopherson
2025-02-13 3:56 ` Suleiman Souhlal
2025-01-07 4:22 ` [PATCH v3 2/3] KVM: x86: Include host suspended time in steal time Suleiman Souhlal
2025-01-07 15:37 ` Sean Christopherson
2025-01-08 4:05 ` Suleiman Souhlal
2025-01-08 15:17 ` Sean Christopherson
2025-01-07 4:22 ` [PATCH v3 3/3] KVM: x86: Document host suspend being included " Suleiman Souhlal
2025-01-07 15:37 ` Sean Christopherson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z31KUrNvDxqyEBsn@google.com \
--to=seanjc@google.com \
--cc=bp@alien8.de \
--cc=chao.gao@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=dwmw2@infradead.org \
--cc=hpa@zytor.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=ssouhlal@freebsd.org \
--cc=suleiman@google.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).