From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f74.google.com (mail-pj1-f74.google.com [209.85.216.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 172FC2FB6 for ; Sat, 11 Jan 2025 00:49:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.74 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736556570; cv=none; b=r0N/16mEWNb+P/R5CGS3vL0jRzUdS0CrYZVv1l5uDH1Rtoeh46g7j/iASJcj8frQIA+iW4X/lm4ktKEeyO6ho1saANEoKZoqvkqtvZtpPH6OqD2n8wcTEg+Re8mUoIKTVV6aQngEBbqSEvi05Ia/EUNdOUueMB7zPs2v7+ScOIM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736556570; c=relaxed/simple; bh=DqbsPM7pbMq3tNO53LpeaJ86ETg2ScGj8LGDaaUTLJM=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=hRbMhszJA58cwjnaVHOkKo1FcWGq/4Jf9sxWDD2L9UPKhzmCifyggouCC6E4vA+IvIL/N4UZ1pL1302MkZ5oBWrvZXI9nS+yNIv6xffNHTgpntROmzssR7sEsh90Yb1t3hlHRzcaQShNcklyV6NPQcI4TYbEfGCUcGRQUdYtcyY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=Nu902t86; arc=none smtp.client-ip=209.85.216.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="Nu902t86" Received: by mail-pj1-f74.google.com with SMTP id 98e67ed59e1d1-2eebfd6d065so6692232a91.3 for ; Fri, 10 Jan 2025 16:49:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1736556567; x=1737161367; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:from:to:cc:subject:date:message-id :reply-to; bh=YX28d/CEykAYv4b51S4uD+A1lpSwnJPjWn7kTo7F+wY=; b=Nu902t86+h2+UCpAerjCkL1TxbV1qTw+ub+wiooHKXwFb+VvD7cGumqCUdu4VdJaVC wQRcVfcjLeG+0OD+ph810tBX2DRJnI1sKuYSWyaYS85EkRagqODZsqYf4Nh5Jlf8MWfU OoblEve0Cu5eGvBTfN0E1VBNgLEwTRwRVkuAOTnlFaUSNboPXKpf4nQ2M4WirwklA9I4 L5GyIAofAqrnmPwlZBuC4nSx6DrCGjg6kLbTs5u6YVuCOjk35n+cCqh7qib4W2uJ3JNQ S6pEt9JhWGBvZ1aI0GBgJXJxfkCn6yXuS2+b6AQTFzW67CTkKeIGuAK/O1p8hz1VGjth 1txg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736556567; x=1737161367; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=YX28d/CEykAYv4b51S4uD+A1lpSwnJPjWn7kTo7F+wY=; b=vgqZwfwDVvLX5rPMWjkYmnebPNm/9kOcCeg4bLdZ4L9/UHck+0LnD58v1HNzBTh/h+ o6CXeK6IfpOm+0WfSmJHx1DCBGqurqVOC+RDAVWCOtABvpLpsSlGrNRs8exsD013H31K +gkS31szghJ+ZlanVFZnZeu0QDZeS16bi7JeTYT5Jxrp8SHEKDfn3RrCPDJgKgSe3lnk G36Wuy2YNPdIhAJH5hAMR9N6sawsVxZmI1+MrYTxkTXZoVTHDJjHS8b4IZk2uela68D6 rqj5jHiCdFZz3/v2/k2ED/uWTXZOQ6YOj/ltismDhAOR9uHm1QkKkR5xC5TVK+JHCswu N/hA== X-Forwarded-Encrypted: i=1; AJvYcCVC11RJDBnEfEJcMFvelXVYqI/bMB7GVoY0ZCMDCQieZ1WTKSnow2fZ+UGYXZmrMyRtNSU=@vger.kernel.org X-Gm-Message-State: AOJu0YwZl+rTgNy2Ny6736lQ+LC8C/3FeIwH1Kc+C6KD48iyi8MXZ5va Y0t/JODltGHoviIXTTSyBr3wdQPea6K31o2oE2EFUmYvP9LI7wPQ0szokNuUSJjRil+CjoRyfLP e6w== X-Google-Smtp-Source: AGHT+IH361hyEP8ZBxDjRVTWmQZDmlNvVhHg1tXUKZ2PrfsrRNnR2/vcWBj5z0ljoK7+gcYBV3qV4n3VGY0= X-Received: from pjbhl13.prod.google.com ([2002:a17:90b:134d:b0:2e0:9fee:4b86]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:2747:b0:2f2:a664:df1a with SMTP id 98e67ed59e1d1-2f548e9c9bcmr19626538a91.2.1736556567441; Fri, 10 Jan 2025 16:49:27 -0800 (PST) Date: Fri, 10 Jan 2025 16:49:26 -0800 In-Reply-To: Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <14f97f58d6150c6784909261db7f9a05d8d32566.1735931639.git.ashish.kalra@amd.com> <6241f868-98ee-592b-9475-7e6cec09d977@amd.com> <8ae7718c-2321-4f3a-b5b7-7fb029d150cf@amd.com> <8adf7f48-dab0-cbed-d920-e3b74d8411cf@amd.com> Message-ID: Subject: Re: [PATCH v3 6/7] KVM: SVM: Add support to initialize SEV/SNP functionality in KVM From: Sean Christopherson To: Dionna Amalie Glaze Cc: Ashish Kalra , Tom Lendacky , pbonzini@redhat.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, john.allen@amd.com, herbert@gondor.apana.org.au, davem@davemloft.net, michael.roth@amd.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, linux-coco@lists.linux.dev Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On Fri, Jan 10, 2025, Dionna Amalie Glaze wrote: > On Fri, Jan 10, 2025 at 4:40=E2=80=AFPM Sean Christopherson wrote: > > > Is there a way to change the load order of built-in modules and/or ch= ange > > > dependency of built-in modules ? > > > > The least awful option I know of would be to have the PSP use a higher = priority > > initcall type so that it runs before the standard initcalls. When comp= iled as > > a module, all initcall types are #defined to module_init. > > > > E.g. this should work, /cross fingers > > > > diff --git a/drivers/crypto/ccp/sp-dev.c b/drivers/crypto/ccp/sp-dev.c > > index 7eb3e4668286..02c49fbf6198 100644 > > --- a/drivers/crypto/ccp/sp-dev.c > > +++ b/drivers/crypto/ccp/sp-dev.c > > @@ -295,5 +295,6 @@ static void __exit sp_mod_exit(void) > > #endif > > } > > > > -module_init(sp_mod_init); > > +/* The PSP needs to be initialized before dependent modules, e.g. befo= re KVM. */ > > +subsys_initcall(sp_mod_init); >=20 > I was 2 seconds from clicking send with this exact suggestion. There > are examples in 'drivers/' that use subsys_initcall / module_exit > pairs. Ha! For once, I wasn't too slow due to writing an overly verbose message := -)