From: Sean Christopherson <seanjc@google.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel test robot <oliver.sang@intel.com>
Subject: Re: [PATCH 0/5] KVM: selftests: Fix PMC checks in PMU counters test
Date: Mon, 10 Feb 2025 15:38:07 -0800 [thread overview]
Message-ID: <Z6qN3wPXH4cbRzLP@google.com> (raw)
In-Reply-To: <CABgObfYuSn225d+Voc=T9am8zUK63v+s3GamohPU2+k0KwERkw@mail.gmail.com>
On Mon, Jan 20, 2025, Paolo Bonzini wrote:
> On Sat, Jan 18, 2025 at 12:42 AM Sean Christopherson <seanjc@google.com> wrote:
> >
> > Fix a flaw in the Intel PMU counters test where it asserts that an event is
> > counting correctly without actually knowing what the event counts given the
> > underlying hardware.
> >
> > The bug manifests as failures with the Top-Down Slots architectural event
> > when running CPUs that doesn't actually support that arch event (pre-ICX).
> > The arch event encoding still counts _something_, just not Top-Down Slots
> > (I haven't bothered to look up what it was counting). The passed by sheer
> > dumb luck until an unrelated change caused the count of the unknown event
> > to drop.
>
> Queued for 6.14-rc1, thanks.
Lies :-)
Neither this nor the main selftests pull request[*] landed in 6.14. None of this
is urgent, so if it's easier on your end I can carry them forward and send them
for 6.15.
[*] https://lore.kernel.org/all/20250117010718.2328467-5-seanjc@google.com
next prev parent reply other threads:[~2025-02-10 23:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-17 23:41 [PATCH 0/5] KVM: selftests: Fix PMC checks in PMU counters test Sean Christopherson
2025-01-17 23:41 ` [PATCH 1/5] KVM: selftests: Make Intel arch events globally available " Sean Christopherson
2025-01-17 23:42 ` [PATCH 2/5] KVM: selftests: Only validate counts for hardware-supported arch events Sean Christopherson
2025-01-18 0:06 ` Mingwei Zhang
2025-01-18 0:39 ` Sean Christopherson
2025-01-20 16:12 ` Paolo Bonzini
2025-01-22 4:51 ` Mingwei Zhang
2025-01-24 15:57 ` Sean Christopherson
2025-01-17 23:42 ` [PATCH 3/5] KVM: selftests: Remove dead code in Intel PMU counters test Sean Christopherson
2025-01-17 23:42 ` [PATCH 4/5] KVM: selftests: Drop the "feature event" param from guest test helpers Sean Christopherson
2025-01-17 23:42 ` [PATCH 5/5] KVM: selftests: Print out the actual Top-Down Slots count on failure Sean Christopherson
2025-01-20 16:17 ` [PATCH 0/5] KVM: selftests: Fix PMC checks in PMU counters test Paolo Bonzini
2025-02-10 23:38 ` Sean Christopherson [this message]
2025-02-15 0:50 ` Sean Christopherson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z6qN3wPXH4cbRzLP@google.com \
--to=seanjc@google.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oliver.sang@intel.com \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox