From: Bobby Eshleman <bobbyeshleman@gmail.com>
To: Stefano Garzarella <sgarzare@redhat.com>
Cc: Jason Wang <jasowang@redhat.com>,
davem@davemloft.net, Stefan Hajnoczi <stefanha@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
linux-kernel@vger.kernel.org, Jorgen Hansen <jhansen@vmware.com>,
kvm@vger.kernel.org, virtualization@lists.linux-foundation.org,
linux-hyperv@vger.kernel.org, Dexuan Cui <decui@microsoft.com>,
netdev@vger.kernel.org, Jakub Kicinski <kuba@kernel.org>
Subject: Re: [PATCH net-next 0/3] vsock: support network namespace
Date: Tue, 4 Mar 2025 16:39:02 -0800 [thread overview]
Message-ID: <Z8edJjqAqAaV3Vkt@devvm6277.cco0.facebook.com> (raw)
In-Reply-To: <20200428160052.o3ihui4262xogyg4@steredhat>
On Tue, Apr 28, 2020 at 06:00:52PM +0200, Stefano Garzarella wrote:
> On Tue, Apr 28, 2020 at 04:13:22PM +0800, Jason Wang wrote:
> >
> >
> > As we've discussed, it should be a netdev probably in either guest or host
> > side. And it would be much simpler if we want do implement namespace then.
> > No new API is needed.
> >
>
> Thanks Jason!
>
> It would be cool, but I don't have much experience on netdev.
> Do you see any particular obstacles?
>
> I'll take a look to understand how to do it, surely in the guest would
> be very useful to have the vsock device as a netdev and maybe also in the host.
>
WRT netdev, do we foresee big gains beyond just leveraging the netdev's
namespace?
IIUC, the idea is that we could follow the tcp/ip model and introduce
vsock-supported netdevs. This would allow us to have a netdev associated
with the virtio-vsock device and create virtual netdev pairs (i.e.,
veth) that can bridge namespaces. Then, allocate CIDs or configure port
mappings for those namespaces?
I think it might be a lot of complexity to bring into the picture from
netdev, and I'm not sure there is a big win since the vsock device could
also have a vsock->net itself? I think the complexity will come from the
address translation, which I don't think netdev buys us because there
would still be all of the work work to support vsock in netfilter?
Some other thoughts I had: netdev's flow control features would all have
to be ignored or disabled somehow (I think dev_direct_xmit()?), because
queueing introduces packet loss and the vsock protocol is unable to
survive packet loss. Netfilter's ability to drop packets would have to
be disabled too.
Best,
Bobby
next prev parent reply other threads:[~2025-03-05 0:39 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-16 17:24 [PATCH net-next 0/3] vsock: support network namespace Stefano Garzarella
2020-01-16 17:24 ` [PATCH net-next 1/3] vsock: add network namespace support Stefano Garzarella
2020-01-20 9:06 ` David Miller
2020-01-20 10:17 ` Stefano Garzarella
2020-01-20 12:03 ` Michael S. Tsirkin
2020-01-20 13:58 ` Stefano Garzarella
2020-01-20 16:04 ` Michael S. Tsirkin
2020-01-20 16:53 ` Stefano Garzarella
2020-01-20 22:02 ` Michael S. Tsirkin
2020-01-21 9:07 ` Stefano Garzarella
2020-01-21 11:14 ` Michael S. Tsirkin
2020-01-21 13:13 ` Stefano Garzarella
2020-01-21 15:43 ` Stefan Hajnoczi
2020-01-21 13:59 ` Stefan Hajnoczi
2020-01-21 14:31 ` Michael S. Tsirkin
2020-01-21 15:44 ` Stefan Hajnoczi
2025-03-05 7:32 ` Michael S. Tsirkin
2025-03-05 9:23 ` Stefano Garzarella
2025-03-05 9:28 ` Michael S. Tsirkin
2025-03-05 9:37 ` Stefano Garzarella
2025-03-05 15:54 ` Bobby Eshleman
2025-03-05 16:07 ` Stefano Garzarella
2025-03-05 20:19 ` Bobby Eshleman
2020-01-16 17:24 ` [PATCH net-next 2/3] vsock/virtio_transport_common: handle netns of received packets Stefano Garzarella
2020-01-16 17:24 ` [PATCH net-next 3/3] vhost/vsock: use netns of process that opens the vhost-vsock device Stefano Garzarella
2020-01-21 15:50 ` [PATCH net-next 0/3] vsock: support network namespace Stefan Hajnoczi
2020-01-22 9:13 ` Stefano Garzarella
2020-04-27 14:25 ` Stefano Garzarella
2020-04-27 14:31 ` Michael S. Tsirkin
2020-04-27 15:21 ` Stefano Garzarella
2020-04-28 8:13 ` Jason Wang
2020-04-28 16:00 ` Stefano Garzarella
2020-04-29 9:21 ` Jason Wang
2025-03-05 0:39 ` Bobby Eshleman [this message]
2025-03-05 5:46 ` Jason Wang
2025-03-10 20:14 ` Bobby Eshleman
2025-03-11 0:59 ` Jason Wang
2025-03-12 22:29 ` Bobby Eshleman
2025-03-05 7:27 ` Michael S. Tsirkin
2025-03-05 9:30 ` Stefano Garzarella
2025-03-05 16:09 ` Bobby Eshleman
2025-03-06 0:16 ` Jason Wang
2025-03-06 1:36 ` Lei Yang
2025-03-06 8:23 ` Stefano Garzarella
2025-03-10 14:14 ` Stefano Garzarella
2025-03-11 0:54 ` Jason Wang
2025-03-11 1:01 ` Jason Wang
2025-03-05 0:06 ` Bobby Eshleman
2025-03-05 9:42 ` Stefano Garzarella
2025-03-05 17:14 ` Bobby Eshleman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z8edJjqAqAaV3Vkt@devvm6277.cco0.facebook.com \
--to=bobbyeshleman@gmail.com \
--cc=davem@davemloft.net \
--cc=decui@microsoft.com \
--cc=jasowang@redhat.com \
--cc=jhansen@vmware.com \
--cc=kuba@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=sgarzare@redhat.com \
--cc=stefanha@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox