Re: [kvm-unit-tests PATCH v1 1/7] arm64: drop to EL1 if booted at EL2

[Alexandru Elisei <alexandru.elisei@arm.com>]

Hi Joey,

On Tue, Mar 04, 2025 at 05:02:13PM +0000, Joey Gouly wrote:
> Hi,
> 
> On Thu, Feb 27, 2025 at 04:53:15PM +0000, Alexandru Elisei wrote:
> > Hi Joey,
> > 
> > On Thu, Feb 20, 2025 at 02:13:48PM +0000, Joey Gouly wrote:
> > > EL2 is not currently supported, drop to EL1 to conitnue booting.
> > > 
> > > Signed-off-by: Joey Gouly <joey.gouly@arm.com>
> > > ---
> > >  arm/cstart64.S | 27 +++++++++++++++++++++++++--
> > >  1 file changed, 25 insertions(+), 2 deletions(-)
> > > 
> > > diff --git a/arm/cstart64.S b/arm/cstart64.S
> > > index b480a552..3a305ad0 100644
> > > --- a/arm/cstart64.S
> > > +++ b/arm/cstart64.S
> > > @@ -57,14 +57,25 @@ start:
> > >  	add     x6, x6, :lo12:reloc_end
> > >  1:
> > >  	cmp	x5, x6
> > > -	b.hs	1f
> > > +	b.hs	reloc_done
> > >  	ldr	x7, [x5]			// r_offset
> > >  	ldr	x8, [x5, #16]			// r_addend
> > >  	add	x8, x8, x4			// val = base + r_addend
> > >  	str	x8, [x4, x7]			// base[r_offset] = val
> > >  	add	x5, x5, #24
> > >  	b	1b
> > > -
> > > +reloc_done:
> > > +	mrs	x4, CurrentEL
> > > +	cmp	x4, CurrentEL_EL2
> > > +	b.ne	1f
> > > +drop_to_el1:
> > > +	mov	x4, 4
> > > +	msr	spsr_el2, x4
> > > +	adrp	x4, 1f
> > > +	add	x4, x4, :lo12:1f
> > > +	msr	elr_el2, x4
> > 
> > I'm going to assume this works because KVM is nice enough to initialise the
> > EL2 registers that affect execution at EL1 to some sane defaults. Is that
> > something that can be relied on going forward?
> 
> I was just trying to keep the changes minimal.

Sure, I appreciate that, and the series looks nice and small because of it, but
in the absence of an ABI from KVM, the reset values for the EL2 registers that
affect execution at EL1 are just an implemention choice that KVM made at a
particular point in time. I don't think robust software should rely on it.

> 
> > 
> > What about UEFI?
> 
> Haven't tested it yet.

Ok, I saw you made changes to the UEFI code so I had assumed to tested them.

> 
> > 
> > I was expecting some kind of initialization of the registers that affect
> > EL1.
> 
> I'll look into it.

Great, thanks. I think arch/arm64/incluse/asm/el2_setup.h might be a useful
starting point. You can put the initialization code in a macro and use it
for the primary and secondaries CPUs, like Marc suggested.

Thanks,
Alex