Re: [PATCH V2 01/12] x86/virt/tdx: Make tdh_vp_enter() noinstr

Adrian Hunter
2025-02-27T14:14:24Z

On 16/02/25 20:26, Paolo Bonzini wrote:
> On 1/29/25 10:58, Adrian Hunter wrote:
>> Make tdh_vp_enter() noinstr because KVM requires VM entry to be noinstr
>> for 2 reasons:
>>   1. The use of context tracking via guest_state_enter_irqoff() and
>>      guest_state_exit_irqoff()
>>   2. The need to avoid IRET between VM-exit and NMI handling in order to
>>      avoid prematurely releasing NMI inhibit.
>>
>> Consequently make __seamcall_saved_ret() noinstr also. Currently
>> tdh_vp_enter() is the only caller of __seamcall_saved_ret().
>>
>> Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
>
> This can be squashed into "x86/virt/tdx: Add SEAMCALL wrapper to enter/exit TDX guest"; I did that in kvm-coco-queue.

We have re-based on kvm-coco-queue so we in-sync on this.