Re: [PATCH v3 05/10] x86/fpu/xstate: Introduce guest FPU configuration

Chao Gao
2025-03-08T03:01:26Z

On Fri, Mar 07, 2025 at 10:06:56AM -0800, Dave Hansen wrote:
>On 3/7/25 08:41, Chao Gao wrote:
>> + fpu_guest_cfg.max_features = fpu_kernel_cfg.max_features;
>> + fpu_guest_cfg.default_features = fpu_guest_cfg.max_features;
>> + fpu_guest_cfg.default_features &= ~XFEATURE_MASK_USER_DYNAMIC;
>
>Is just copying and pasting the 'fpu_kernel_cfg' initialization really
>the best way to explain what's going on?
>
>Let's say you just did:
>
> fpu_guest_cfg = fpu_kernel_cfg;
>
>?
>
>That would explicitly tell the reader that they're equal.
>

Yes. This is much better.

>