Re: [PATCH v3 09/10] x86/fpu/xstate: Introduce XFEATURE_MASK_KERNEL_DYNAMIC xfeature set

Chang S. Bae
2025-03-12T01:04:53Z

On 3/11/2025 5:27 AM, Chao Gao wrote:
>
> I dug through the history and found a discussion about the naming at:
>
> https://lore.kernel.org/all/893ac578-baaf-4f4f-96ee-e012dfc073a8@intel.com/#t

Okay, it looks like you've finally captured the full context!

> I think I should revise the changelog to call out why 'DYNAMIC' is preferred
> over 'GUEST' and reference that discussion.

You might want to take some time to think about some code comments when
defining the feature. I think 'independent feature' is a good example to
look at:

https://web.git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/x86/include/asm/fpu/xstate.h#n53

Thanks,
Chang