Re: [PATCH v3 04/10] x86/fpu/xstate: Correct guest fpstate size calculation

Chang S. Bae
2025-03-07T21:37:23Z

On 3/7/2025 8:41 AM, Chao Gao wrote:
>
> diff --git a/arch/x86/kernel/fpu/core.c b/arch/x86/kernel/fpu/core.c
> index 6166a928d3f5..adc34914634e 100644
> --- a/arch/x86/kernel/fpu/core.c
> +++ b/arch/x86/kernel/fpu/core.c
> @@ -218,7 +218,7 @@ bool fpu_alloc_guest_fpstate(struct fpu_guest *gfpu)
> struct fpstate *fpstate;
> unsigned int size;
>
> - size = fpu_user_cfg.default_size + ALIGN(offsetof(struct fpstate, regs), 64);
> + size = fpu_kernel_cfg.default_size + ALIGN(offsetof(struct fpstate, regs), 64);
> fpstate = vzalloc(size);
> if (!fpstate)
> return false;

BTW, did you ever base this series on the tip/master branch? The fix has
already been merged there:

1937e18cc3cf ("x86/fpu: Fix guest FPU state buffer allocation size")

Thanks,
Chang