From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B708FC6FD1C for ; Fri, 24 Mar 2023 20:39:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232173AbjCXUjv (ORCPT ); Fri, 24 Mar 2023 16:39:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57208 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230015AbjCXUjt (ORCPT ); Fri, 24 Mar 2023 16:39:49 -0400 Received: from mail-yb1-xb49.google.com (mail-yb1-xb49.google.com [IPv6:2607:f8b0:4864:20::b49]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8F1881EBC6 for ; Fri, 24 Mar 2023 13:39:36 -0700 (PDT) Received: by mail-yb1-xb49.google.com with SMTP id 185-20020a250ac2000000b00b6d0cdc8e3bso2840656ybk.4 for ; Fri, 24 Mar 2023 13:39:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; t=1679690376; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=fWNApcsVqs6b8iyHjgouP8WjDbrbEDYT6YEA+91Iaa0=; b=Wkk8GoBMBfAaO8icCREFAmzcGXiN4+5z5fgoxnmaFd/mRFjAqra6kFilc9+/P2Qw4I 4lEXB8v9R7Dq8iR4IbzrGXtwP0KHP6ErspCQ8wPGgksbkxb3g+Zkqy7VoSMrSeuuZR7u 33Zrs+DmbpgyjaZa+lufLbAbv/Nr4P/Nh11ixJRvOmPLcGGVFjYRcieZ0Q+bygPlqCfx O28jcMtLnxqeSaELNfF7gYOupZwHuDvSbzEXLMN8SCosbtO4hxVQ7uvwyKsljVG2GJfu AW+sg+oTbGR9JWn9XoB0BAXxQ2VTXp1RR92nPgmBgOp+gmPSYNDeacU02bOjWr4nP8lL 2iGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679690376; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=fWNApcsVqs6b8iyHjgouP8WjDbrbEDYT6YEA+91Iaa0=; b=4lx0iqtD1NJEGw9dvzNk8R9fhrpU1rm2veOtIMhBT99RwFWqpo+o5Veui8byJqQSA8 n/KvFbTvaoN0deLt+7ZQwqCZRXpqbP1Ygbzlm/2ehhgdqQMVGJBfXRTfZBhJrd+4c49j ZJp36ySTd+1kAeiK+UV8rphpsXuG3SaQ1z6Y+7P2IXQ6MZsODj99i9tsqVRTGAFo7T10 zw23Wa8jb6QHyqPUFkDKy8GdAe3euwD/HCYUJb6HhwGU7qqhiHzaDnV2HggjwDixATA2 OwQBBwiughcXrWwxgwmlv7m+Oh0DiJPbLzzI8evGGD4zo5XMjHhq6iXxwBDo8Lgdgt/D ny2Q== X-Gm-Message-State: AAQBX9f1guXV7rnIKcs8BsznSWWpSw3S8NclexKrpqEW9RKfMDyV2dbe udmBWXNzj61o7c29bch5woAy3rXKVh8= X-Google-Smtp-Source: AKy350Y6SEOlHkFCPWC9itRys/kTTth6Cx5cpdUd5JwKTc5t6cutcKsk4wv32TGpACgnm9ef/9QbZ1rGhmI= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a05:6902:10c3:b0:b75:9519:dbcd with SMTP id w3-20020a05690210c300b00b759519dbcdmr2229922ybu.12.1679690375846; Fri, 24 Mar 2023 13:39:35 -0700 (PDT) Date: Fri, 24 Mar 2023 13:39:34 -0700 In-Reply-To: <20230221163655.920289-7-mizhang@google.com> Mime-Version: 1.0 References: <20230221163655.920289-1-mizhang@google.com> <20230221163655.920289-7-mizhang@google.com> Message-ID: Subject: Re: [PATCH v3 06/13] KVM: selftests: x86: Add the XFD check to IA32_XFD in #NM handler From: Sean Christopherson To: Mingwei Zhang Cc: Paolo Bonzini , Thomas Gleixner , "H. Peter Anvin" , linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-kselftest@vger.kernel.org, Jim Mattson , Venkatesh Srinivas , Aaron Lewis , "Chang S. Bae" , Chao Gao Content-Type: text/plain; charset="us-ascii" Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Tue, Feb 21, 2023, Mingwei Zhang wrote: > Add an extra check to IA32_XFD to ensure the behavior is consistent with > the AMX archtecture. In addition, repeat the checks across context switch > to ensure the values of IA32_XFD and IA32_XFD_ERR are well preserved. > > Signed-off-by: Mingwei Zhang > --- > tools/testing/selftests/kvm/x86_64/amx_test.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/tools/testing/selftests/kvm/x86_64/amx_test.c b/tools/testing/selftests/kvm/x86_64/amx_test.c > index ac49b14460b6..296c954dfd6d 100644 > --- a/tools/testing/selftests/kvm/x86_64/amx_test.c > +++ b/tools/testing/selftests/kvm/x86_64/amx_test.c > @@ -218,8 +218,10 @@ void guest_nm_handler(struct ex_regs *regs) > GUEST_SYNC(7); > GUEST_ASSERT((get_cr0() & X86_CR0_TS) == 0); > GUEST_ASSERT(rdmsr(MSR_IA32_XFD_ERR) == XFEATURE_MASK_XTILEDATA); > + GUEST_ASSERT(rdmsr(MSR_IA32_XFD) & XFEATURE_MASK_XTILEDATA); These should use ==, not &. The test explicitly writes MSR_IA32_XFD, i.e. if there are extra bits set then something is buggy.