From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8E00C6FD1C for ; Fri, 24 Mar 2023 20:41:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232183AbjCXUln (ORCPT ); Fri, 24 Mar 2023 16:41:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59918 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231889AbjCXUlm (ORCPT ); Fri, 24 Mar 2023 16:41:42 -0400 Received: from mail-yw1-x1149.google.com (mail-yw1-x1149.google.com [IPv6:2607:f8b0:4864:20::1149]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3E0251E1C2 for ; Fri, 24 Mar 2023 13:41:41 -0700 (PDT) Received: by mail-yw1-x1149.google.com with SMTP id 00721157ae682-5417f156cb9so29806367b3.8 for ; Fri, 24 Mar 2023 13:41:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; t=1679690500; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=7c0elEDxGGtgZ98ipBv9YG9bKIImebaxGJ+PlUUC8zU=; b=mQ7hRAyFPVoiNHCCnDfThBXLCS64L7JF/OLnQv7tZjk2JaTturO9bNHKXpmrWQS9St 0YKGbhmvzmtTNahzMngL7TJc7N1UFkvRccJ9YRCU21E+CMwgKiqZErYDzaxtZOoM/ISv 5Dk3MRwB4SCrpgONU56QI0o8689QBjnxDlnBp/6dBMQMXaFBnuf7fvpLAcN5pek98WOp sQDwFL4K2d6G07ASWTtAILpG+Lp2PZR/B9SdmJ8UbWIUK9A5+O2Hjz5bLjYBFPBT5O5w 5DtjxUicpxVAGsWos/+CU5RfKjBCuuq2IPM2XfagLBU5KnFhp4lrWRT9rxSZD1KtEvpI TCDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679690500; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7c0elEDxGGtgZ98ipBv9YG9bKIImebaxGJ+PlUUC8zU=; b=BFdOMvKvviUgLMIr62wgYGlPcQyPIDLqsxpEh+owOhqbowo9HFERW+kCxX/YXfMKxQ vGXwzHqUo9EpLfknvGfuwKSV62XCFCEjY3BCTN8u9p/DpHPQ6WT0dUy+Gn5sxPaHoDEw NMTHQox5kLVPWn1oe23RI2tJNxpk3IHxliJnHVMLaIxLJ8ecANFy4RoLD+doIGOyhy3l uUk/12oAh3x8AK8O/ppe+WJwszlpSwF94GxT0MimFl7/dY95FiVUcIBqUzBNOKsCiU76 KPWjlMdGkXIza18ppS8WZFavkiDrlWWUJl5FsGTLKtE4KdoRfj3whjUPIYWvV2uRJjEU rl8w== X-Gm-Message-State: AAQBX9cbC10QvAkqET6Fg8pqZzgts3+FD6FMvlPu0AQRmZ/8cTtUAvo/ ADBABuxF6q0XvX65YsyumCX8YzY0h+Q= X-Google-Smtp-Source: AKy350btV5WNqzErKtxiHAqBrc74aEG4o3U784IbaSpYUXuHaUKrnkflNxJZVCzDKHG61J0a7gJ//m/aT38= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a25:cf81:0:b0:b76:ceb2:661d with SMTP id f123-20020a25cf81000000b00b76ceb2661dmr1699796ybg.7.1679690500564; Fri, 24 Mar 2023 13:41:40 -0700 (PDT) Date: Fri, 24 Mar 2023 13:41:39 -0700 In-Reply-To: <20230221163655.920289-8-mizhang@google.com> Mime-Version: 1.0 References: <20230221163655.920289-1-mizhang@google.com> <20230221163655.920289-8-mizhang@google.com> Message-ID: Subject: Re: [PATCH v3 07/13] KVM: selftests: x86: Fix the checks to XFD_ERR using and operation From: Sean Christopherson To: Mingwei Zhang , g@google.com Cc: Paolo Bonzini , Thomas Gleixner , "H. Peter Anvin" , linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-kselftest@vger.kernel.org, Jim Mattson , Venkatesh Srinivas , Aaron Lewis , "Chang S. Bae" , Chao Gao Content-Type: text/plain; charset="us-ascii" Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Tue, Feb 21, 2023, Mingwei Zhang wrote: > Fix the checks to XFD_ERR using logical AND operation because XFD_ERR might > contain more information in the future. According Intel SDM Vol 1. 13.14: If that happens, then the future change is responsible for updating the check. The test very clearly does a straight write of MSR_IA32_XFD. If there are extra bits set then something is broken. wrmsr(MSR_IA32_XFD, XFEATURE_MASK_XTILEDATA);