From: Sean Christopherson <seanjc@google.com>
To: pbonzini@redhat.com, shuah@kernel.org, dmatlack@google.com,
kvm@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org,
Ackerley Tng <ackerleytng@google.com>
Cc: erdemaktas@google.com, vannapurve@google.com, sagis@google.com,
mail@maciej.szmigiero.name
Subject: Re: [PATCH v2 1/1] KVM: selftests: Adjust VM's initial stack address to align with SysV ABI spec
Date: Fri, 24 Mar 2023 14:27:16 -0700 [thread overview]
Message-ID: <ZB4VtIPZjDGwuPOc@google.com> (raw)
In-Reply-To: <167969137156.2756401.15618241992481271147.b4-ty@google.com>
On Fri, Mar 24, 2023, Sean Christopherson wrote:
> On Mon, 27 Feb 2023 18:06:01 +0000, Ackerley Tng wrote:
> > Align the guest stack to match calling sequence requirements in
> > section "The Stack Frame" of the System V ABI AMD64 Architecture
> > Processor Supplement, which requires the value (%rsp + 8), NOT %rsp,
> > to be a multiple of 16 when control is transferred to the function
> > entry point. I.e. in a normal function call, %rsp needs to be 16-byte
> > aligned _before_ CALL, not after.
> >
> > [...]
>
> Applied to kvm-x86 selftests, thanks!
>
> [1/1] KVM: selftests: Adjust VM's initial stack address to align with SysV ABI spec
> https://github.com/kvm-x86/linux/commit/1982754bd2a7
Force pushed to selftests 'cause I had a goof, this now:
KVM: selftests: Adjust VM's initial stack address to align with SysV ABI spec
https://github.com/kvm-x86/linux/commit/8264e85560e5
prev parent reply other threads:[~2023-03-24 21:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-27 18:06 [PATCH v2 1/1] KVM: selftests: Adjust VM's initial stack address to align with SysV ABI spec Ackerley Tng
2023-03-24 20:58 ` Sean Christopherson
2023-03-24 21:27 ` Sean Christopherson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZB4VtIPZjDGwuPOc@google.com \
--to=seanjc@google.com \
--cc=ackerleytng@google.com \
--cc=dmatlack@google.com \
--cc=erdemaktas@google.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mail@maciej.szmigiero.name \
--cc=pbonzini@redhat.com \
--cc=sagis@google.com \
--cc=shuah@kernel.org \
--cc=vannapurve@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox