From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3B96C6FD1D for ; Mon, 20 Mar 2023 19:00:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229679AbjCTTAh (ORCPT ); Mon, 20 Mar 2023 15:00:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45862 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230501AbjCTS73 (ORCPT ); Mon, 20 Mar 2023 14:59:29 -0400 Received: from mail-pl1-x649.google.com (mail-pl1-x649.google.com [IPv6:2607:f8b0:4864:20::649]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5592C2A6C9 for ; Mon, 20 Mar 2023 11:51:18 -0700 (PDT) Received: by mail-pl1-x649.google.com with SMTP id k17-20020a170902d59100b0019abcf45d75so7476736plh.8 for ; Mon, 20 Mar 2023 11:51:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; t=1679338273; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=cwkFpfls1/6cud8wVygwf0ElwmaxIhRMsIsiLVuOOos=; b=Dayu5fXCeLh47JsqiwpPciLjIjD3C0AAkOu61sC4pfDZuHIdddVPd9TBc7TrdvKaDs AesZNjWXlmN17p9fJyicCR9PmN9TQLMNsjZAaVj6jTeOHDai4456vD8cPE2gsFgNtmxw MzLQI5orQwtXhkBsCWC3pR7sKeepT8ci/xa4MND7VukYX7sfxi239uHpFR34abjq/95M 4XZnLldT8gzO0pK1If53cNhanwUlb7QHf6h6SBOtG31tWABLvD3h9NVEKsDZUKJFCIGQ QorZSyegkyPc7JEL7Q6IjXeWMxAws8+jXaQmACJVt+bHpvkmMe+hLyjiIpAR/vKXPk5Z tyDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679338273; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=cwkFpfls1/6cud8wVygwf0ElwmaxIhRMsIsiLVuOOos=; b=OpL4DwiZQRwDjZTa56Kgo+4102v2mGyRmZz/2526nQKhXEW2LjHp8AYlP+hmO5ytpW I+ggPAnH3dGwmRiGK38gkbzxnd1Zq6q0GM7+w56nQTHaKfR6CJx1bhLAz4DjS/ewRbnP v5h7QWMz/JmcaJ3NFGq5JylX/R3f1xKg6H7gk5aFjkdysnJ+38Tq5gdATzk++M8t6luT PF+HRJaujc3ZsSLNLf1GXIXUD4nYRwlsMVGxroMAh0LvbyKd21epky+I8uxyEWMzCuo3 DoAvrr4etd/kDprtra/11tfsp4BVHJ+h+evsAjhbw6HHH/hrPrGA8+0Z1ZJ9gwGH2fiL GjyA== X-Gm-Message-State: AO0yUKUmndon/U+9VL2Fk5+DbnqHYxC3J8gX3husPzPadkkHvzzi/tKd njmq/qzbOok1GFrs/ECxWq3PCffZV34= X-Google-Smtp-Source: AK7set9SaMo9esIin3QfhGtaAPr+Taa8pf+AmaYxRZlcsspkh3rbeDuEeWeqSJzmoNUbCuc7Is5QXPbYerU= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a17:90a:69a1:b0:23f:695a:1355 with SMTP id s30-20020a17090a69a100b0023f695a1355mr60129pjj.5.1679338273401; Mon, 20 Mar 2023 11:51:13 -0700 (PDT) Date: Mon, 20 Mar 2023 11:51:11 -0700 In-Reply-To: <20230202182809.1929122-7-bgardon@google.com> Mime-Version: 1.0 References: <20230202182809.1929122-1-bgardon@google.com> <20230202182809.1929122-7-bgardon@google.com> Message-ID: Subject: Re: [PATCH 06/21] KVM: x86/mmu: Get rid of is_cpuid_PSE36() From: Sean Christopherson To: Ben Gardon Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, Paolo Bonzini , Peter Xu , David Matlack , Vipin Sharma , Ricardo Koller Content-Type: text/plain; charset="us-ascii" Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Thu, Feb 02, 2023, Ben Gardon wrote: > is_cpuid_PSE36() always returns 1 and is never overridden, so just get > rid of the function. This saves having to export it in a future commit > in order to move the include of paging_tmpl.h out of mmu.c. Probably won't matter as I suspect this series is going to end up a burner way in the back, but FWIW I'd prefer to preserve is_cpuid_PSE36() in some capacity. I 100% agree the helper is silly, but the mere existice of the flag is so esoteric these days that I like having obvious/obnoxious code to call it out.