From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DEC6AC6FD1D for ; Mon, 27 Mar 2023 17:44:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229862AbjC0RoA (ORCPT ); Mon, 27 Mar 2023 13:44:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47344 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229934AbjC0Rn6 (ORCPT ); Mon, 27 Mar 2023 13:43:58 -0400 Received: from mail-yw1-x1149.google.com (mail-yw1-x1149.google.com [IPv6:2607:f8b0:4864:20::1149]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EB454170C for ; Mon, 27 Mar 2023 10:43:57 -0700 (PDT) Received: by mail-yw1-x1149.google.com with SMTP id 00721157ae682-545d3b026a8so45248307b3.7 for ; Mon, 27 Mar 2023 10:43:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; t=1679939037; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=XlpSa++Ck7W+hH+1OiuQ4wL4Keih2CLgElX+Jr8IDOg=; b=NRewYmivbp7xrd5bl7JWEYaQ9BEiQxehXzYs4JPD27Ag/vs1+EGoigQA/eGrdDVwpI 6HrxgSZwown5PltC2Waeqpp6KGdrJb/dSApcJ1OUEukUIu3e0Ezq/NVjnhkAzin2oeIi XSws12m/6pB4Il8LiHkXWqb8AJMCdtVH2B+cO5e4Nti183f4YVeFl+atpkWvaCwSlrLh LmtRmg6bJTE0Nq9XTncpVNfM5/aW7PEvzyPI3l+G5UFhZ8iI/LdGA8oPEpZSPXw4sf/Y oWbVtkgHQtAjTuo6pRD+inMv48nJ8KN5jmFbZAnYg8/yiZPVZ9a4faH4l6132Clgz6B7 ZpZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679939037; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=XlpSa++Ck7W+hH+1OiuQ4wL4Keih2CLgElX+Jr8IDOg=; b=0ya8P2CggIJUdmPbkL7yjnfaZ6Bc+Muu51yxzY+X/IhYbDh3BAGl4uQeGCk+bC8k6s XBTl3NhLDt95nULIfBaOBIl4DFb+/NIpALVeU2MSbybkBDva4LbRuBnUEWX3wjr81Y/3 ZKIebbRxbxUJLlH2l4Mg4byevlg3AXWVAXG+dJ9v40lSdfB1BQ7N18WpvhhYbw1hB5p8 X/kfR0/emSRMneScdzELutxv/2N7tCWZc2Ywqqukv6RTzqeACXEOw11p1EsV2N3irovh tKt5UGOaTFu2z+Bsd/UCbYIj4cWWWtmKNJWaEPqzVR1TZtIfWrWOU4CyVUDtX6sa66ma CMcg== X-Gm-Message-State: AAQBX9dm7gExxZd6YBFsExUtvoZpstF/WiKzJAi6/rirKpr3StU6V2fi /TdYO3HP4r7K5b+OD8k1ksubZpPeyzA= X-Google-Smtp-Source: AKy350YnFdRnDAztI/QAWGplLtVR70FJRJ184l6fxPJaxU9DXrlOhocThQPENwgRN3HxnQV8PG1Jwq59fUM= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a05:6902:1141:b0:b73:caa7:f06f with SMTP id p1-20020a056902114100b00b73caa7f06fmr7834435ybu.5.1679939037193; Mon, 27 Mar 2023 10:43:57 -0700 (PDT) Date: Mon, 27 Mar 2023 10:43:55 -0700 In-Reply-To: Mime-Version: 1.0 References: <20230316031732.3591455-1-npiggin@gmail.com> <87ilf0nc95.fsf@mpe.ellerman.id.au> Message-ID: Subject: Re: [PATCH 0/2] KVM: PPC: support kvm selftests From: Sean Christopherson To: Nicholas Piggin Cc: Michael Ellerman , Paolo Bonzini , Shuah Khan , linuxppc-dev@lists.ozlabs.org, kvm@vger.kernel.org, linux-kselftest@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Mon, Mar 27, 2023, Nicholas Piggin wrote: > On Thu Mar 23, 2023 at 3:41 AM AEST, Sean Christopherson wrote: > > On Thu, Mar 16, 2023, Michael Ellerman wrote: > > > Nicholas Piggin writes: > > > > Hi, > > > > > > > > This series adds initial KVM selftests support for powerpc > > > > (64-bit, BookS). > > > > > > Awesome. > > > > > > > It spans 3 maintainers but it does not really > > > > affect arch/powerpc, and it is well contained in selftests > > > > code, just touches some makefiles and a tiny bit headers so > > > > conflicts should be unlikely and trivial. > > > > > > > > I guess Paolo is the best point to merge these, if no comments > > > > or objections? > > > > > > Yeah. If it helps: > > > > > > Acked-by: Michael Ellerman (powerpc) > > > > What is the long term plan for KVM PPC maintenance? I was under the impression > > that KVM PPC was trending toward "bug fixes only", but the addition of selftests > > support suggests otherwise. > > We plan to continue maintaining it. New support and features has been a > bit low in the past couple of years, hopefully that will pick up a bit > though. Partly out of curiosity, but also to get a general feel for what types of changes we might see, what are the main use cases for KVM PPC these days? E.g. is it mainly a vehicle for developing and testing, hosting VMs in the cloud, something else? > > I ask primarily because routing KVM PPC patches through the PPC tree is going to > > be problematic if KVM PPC sees signficiant development. The current situation is > > ok because the volume of patches is low and KVM PPC isn't trying to drive anything > > substantial into common KVM code, but if that changes... > > Michael has done KVM topic branches to pull from a few times when such > conflicts came up (at smaller scale). If we end up with larger changes > or regular conflicts we might start up a kvm-ppc tree again I guess. A wait-and-see approach works for me. I don't have any complaints with the current process, I was just caught off guard. > > My other concern is that for selftests specifically, us KVM folks are taking on > > more maintenance burden by supporting PPC. AFAIK, none of the people that focus > > on KVM selftests in any meaningful capacity have access to PPC hardware, let alone > > know enough about the architecture to make intelligent code changes. > > > > Don't get me wrong, I'm very much in favor of more testing, I just don't want KVM > > to get left holding the bag. > > Understood. I'll be happy to maintain powerpc part of kvm selftests and > do any fixes that are needed for core code changes.If support fell away > you could leave it broken (or rm -rf it if you prefer) -- I wouldn't ask > anybody to work on archs they don't know or aren't paid to. > > Not sure if anything more can be done to help your process or ease your > mind. It (KVM and kvm-selftests) can run in QEMU at least. Updating the KVM/powerpc to include selftests would be very helpful, e.g F: tools/testing/selftests/kvm/*/powerpc/ F: tools/testing/selftests/kvm/powerpc/ and ideally there would be one or more M: (and R:) entries as well. I'm not all that concerned about the selftests support being abandoned, but the lack of specific contacts makes it look like KVM PPC is in maintenance-only mode, and it sounds like that's not the case. Thanks!