public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Sean Christopherson <seanjc@google.com>
To: Thomas Huth <thuth@redhat.com>
Cc: kvm@vger.kernel.org, Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [kvm-unit-tests PATCH] ci/cirrus-ci-fedora.yml: Disable the "memory" test in the KVM job
Date: Mon, 3 Apr 2023 08:24:48 -0700	[thread overview]
Message-ID: <ZCrvwEhb45cqGhmP@google.com> (raw)
In-Reply-To: <20230403112625.63833-1-thuth@redhat.com>

On Mon, Apr 03, 2023, Thomas Huth wrote:
> Two of the sub-tests are currently failing in the Fedora KVM job
> on Cirrus-CI:
> 
> FAIL: clflushopt (ABSENT)
> FAIL: clwb (ABSENT)
> 
> Looks like the features have been marked as disabled in the L0 host,
> while the hardware supports them. Since neither VMX nor SVM have
> intercept controls for the instructions, KVM has no way to enforce the
> guest's CPUID model, so this test is failing now in this environment.
> There's not much we can do here except for disabling the test here.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  ci/cirrus-ci-fedora.yml | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/ci/cirrus-ci-fedora.yml b/ci/cirrus-ci-fedora.yml
> index 918c9a36..c83aff46 100644
> --- a/ci/cirrus-ci-fedora.yml
> +++ b/ci/cirrus-ci-fedora.yml
> @@ -35,7 +35,6 @@ fedora_task:
>          ioapic
>          ioapic-split
>          kvmclock_test
> -        memory

What if we fix the test by making it TCG-only?  None of the other instructions in
the test have intercepts, i.e. will also fail if the instructions are supported in
bare metal but not the test VM.

An alternative would be to force emulation when using KVM, but KVM doesn't currently
emulating pcommit (deprecated by Intel), clwb, or any of the fence instructions
(at least, not afaict; I'm somewhat surprised *fence isn't "required").

diff --git a/x86/unittests.cfg b/x86/unittests.cfg
index f324e32d..5afb5dad 100644
--- a/x86/unittests.cfg
+++ b/x86/unittests.cfg
@@ -185,6 +185,7 @@ arch = x86_64
 
 [memory]
 file = memory.flat
+accel = tcg
 extra_params = -cpu max
 arch = x86_64

  reply	other threads:[~2023-04-03 15:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-03 11:26 [kvm-unit-tests PATCH] ci/cirrus-ci-fedora.yml: Disable the "memory" test in the KVM job Thomas Huth
2023-04-03 15:24 ` Sean Christopherson [this message]
2023-04-03 16:24   ` Paolo Bonzini
2023-04-03 16:51     ` Sean Christopherson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZCrvwEhb45cqGhmP@google.com \
    --to=seanjc@google.com \
    --cc=kvm@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox