From: Sean Christopherson <seanjc@google.com>
To: Aaron Lewis <aaronlewis@google.com>
Cc: kvm@vger.kernel.org, pbonzini@redhat.com, jmattson@google.com
Subject: Re: [PATCH 4/8] KVM: selftests: Copy printf.c to KVM selftests
Date: Tue, 18 Apr 2023 08:03:53 -0700 [thread overview]
Message-ID: <ZD6xWYI7Uin01fA7@google.com> (raw)
In-Reply-To: <ZD1sx+G2oWchaleW@google.com>
On Mon, Apr 17, 2023, Aaron Lewis wrote:
> On Thu, Mar 23, 2023, Sean Christopherson wrote:
> > > +static char *number(char *str, long num, int base, int size, int precision,
> > > + int type)
> >
> > Do we actually need a custom number()? I.e. can we sub in a libc equivalent?
> > That would reduce the craziness of this file by more than a few degrees.
>
> Yeah, I think we need it. One of the biggest problems I'm trying to avoid
> here is the use of LIBC in a guest. Using it always seems to end poorly
> because guests generally don't set up AVX-512 or a TLS segmet, nor should
> they have to. Calling into LIBC seems to require both of them too often,
> so it seems like it's better to just avoid it.
True, we'd probably end up in a world of hurt.
I was going to suggest copy+pasting from a different source, e.g. musl, in the
hopes of reducing the crazy by a degree, but after looking at the musl source,
that's a terrible idea :-)
And copying from the kernel has the advantage of keeping any bugs/quirks that
users may be expecting and/or relying on.
next prev parent reply other threads:[~2023-04-18 15:04 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-01 5:34 [PATCH 0/8] Add printf and formatted asserts in the guest Aaron Lewis
2023-03-01 5:34 ` [PATCH 1/8] KVM: selftests: Hoist XGETBV and XSETBV to make them more accessible Aaron Lewis
2023-03-01 5:34 ` [PATCH 2/8] KVM: selftests: Add XFEATURE masks to common code Aaron Lewis
2023-03-01 5:34 ` [PATCH 3/8] KVM: selftests: Add strnlen() to the string overrides Aaron Lewis
2023-03-01 5:34 ` [PATCH 4/8] KVM: selftests: Copy printf.c to KVM selftests Aaron Lewis
2023-03-23 22:04 ` Sean Christopherson
2023-04-17 15:59 ` Aaron Lewis
2023-04-18 15:03 ` Sean Christopherson [this message]
2023-04-18 16:06 ` Andrew Jones
2023-04-20 17:50 ` Sean Christopherson
2023-04-21 6:03 ` Andrew Jones
2023-03-01 5:34 ` [PATCH 5/8] KVM: selftests: Add vsprintf() " Aaron Lewis
2023-03-23 21:59 ` Sean Christopherson
2023-04-17 16:08 ` Aaron Lewis
2023-04-18 15:04 ` Sean Christopherson
2023-03-01 5:34 ` [PATCH 6/8] KVM: selftests: Add additional pages to the guest to accommodate ucall Aaron Lewis
2023-03-23 22:07 ` Sean Christopherson
2023-03-01 5:34 ` [PATCH 7/8] KVM: selftests: Add string formatting options to ucall Aaron Lewis
2023-03-01 8:07 ` Shaoqin Huang
2023-03-02 14:52 ` Aaron Lewis
2023-03-23 22:12 ` Sean Christopherson
2023-03-01 5:34 ` [PATCH 8/8] KVM: selftests: Add a selftest for guest prints and formatted asserts Aaron Lewis
2023-03-23 20:57 ` [PATCH 0/8] Add printf and formatted asserts in the guest Sean Christopherson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZD6xWYI7Uin01fA7@google.com \
--to=seanjc@google.com \
--cc=aaronlewis@google.com \
--cc=jmattson@google.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).