Kernel KVM virtualization development
 help / color / mirror / Atom feed
From: Alexandru Elisei <alexandru.elisei@arm.com>
To: Andrew Jones <andrew.jones@linux.dev>
Cc: Eric Auger <eric.auger@redhat.com>,
	eric.auger.pro@gmail.com, kvm@vger.kernel.org,
	kvmarm@lists.linux.dev, maz@kernel.org, will@kernel.org,
	oliver.upton@linux.dev, ricarkol@google.com, reijiw@google.com
Subject: Re: [kvm-unit-tests PATCH 0/6] arm: pmu: Fix random failures of pmu-chain-promotion
Date: Wed, 12 Apr 2023 09:55:18 +0100	[thread overview]
Message-ID: <ZDZx9uPIZVKEhQTw@monolith.localdoman> (raw)
In-Reply-To: <7l36wddzolsq7psm5gvra7w6emzlojj5utn7pnrsmwyx6v6jh7@zzrrwbty5zfq>

Hi,

On Wed, Apr 12, 2023 at 09:34:36AM +0200, Andrew Jones wrote:
> On Tue, Apr 04, 2023 at 02:47:49PM +0200, Andrew Jones wrote:
> > On Tue, Apr 04, 2023 at 08:23:15AM +0200, Eric Auger wrote:
> > > Hi,
> > > 
> > > On 3/15/23 12:07, Eric Auger wrote:
> > > > On some HW (ThunderXv2), some random failures of
> > > > pmu-chain-promotion test can be observed.
> > > >
> > > > pmu-chain-promotion is composed of several subtests
> > > > which run 2 mem_access loops. The initial value of
> > > > the counter is set so that no overflow is expected on
> > > > the first loop run and overflow is expected on the second.
> > > > However it is observed that sometimes we get an overflow
> > > > on the first run. It looks related to some variability of
> > > > the mem_acess count. This variability is observed on all
> > > > HW I have access to, with different span though. On
> > > > ThunderX2 HW it looks the margin that is currently taken
> > > > is too small and we regularly hit failure.
> > > >
> > > > although the first goal of this series is to increase
> > > > the count/margin used in those tests, it also attempts
> > > > to improve the pmu-chain-promotion logs, add some barriers
> > > > in the mem-access loop, clarify the chain counter
> > > > enable/disable sequence.
> > > >
> > > > A new 'pmu-memaccess-reliability' is also introduced to
> > > > detect issues with MEM_ACCESS event variability and make
> > > > the debug easier.
> > > >
> > > > Obviously one can wonder if this variability is something normal
> > > > and does not hide any other bug. I hope this series will raise
> > > > additional discussions about this.
> > > >
> > > > https://github.com/eauger/kut/tree/pmu-chain-promotion-fixes-v1
> > > 
> > > Gentle ping.
> > 
> > I'd be happy to take this, but I was hoping to see some r-b's and/or t-b's
> > from some of the others.
> 
> Any takers? Ricardo? Alexandru?

Will try to have a look as soon as I can, and run some tests, am hoping this
week (but no promises!).

Thanks,
Alex

> 
> Thanks,
> drew

  reply	other threads:[~2023-04-12  8:56 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-15 11:07 [kvm-unit-tests PATCH 0/6] arm: pmu: Fix random failures of pmu-chain-promotion Eric Auger
2023-03-15 11:07 ` [kvm-unit-tests PATCH 1/6] arm: pmu: pmu-chain-promotion: Improve debug messages Eric Auger
2023-04-21  9:25   ` Alexandru Elisei
2023-04-24 20:09     ` Eric Auger
2023-03-15 11:07 ` [kvm-unit-tests PATCH 2/6] arm: pmu: pmu-chain-promotion: Introduce defines for count and margin values Eric Auger
2023-04-21  9:55   ` Alexandru Elisei
2023-04-24 20:09     ` Eric Auger
2023-03-15 11:07 ` [kvm-unit-tests PATCH 3/6] arm: pmu: Add extra DSB barriers in the mem_access loop Eric Auger
2023-04-21 10:25   ` Alexandru Elisei
2023-04-24 20:11     ` Eric Auger
2023-04-25 13:00       ` Alexandru Elisei
2023-03-15 11:07 ` [kvm-unit-tests PATCH 4/6] arm: pmu: Fix chain counter enable/disable sequences Eric Auger
2023-04-21 10:52   ` Alexandru Elisei
2023-04-21 11:24     ` Marc Zyngier
2023-03-15 11:07 ` [kvm-unit-tests PATCH 5/6] arm: pmu: Add pmu-memaccess-reliability test Eric Auger
2023-04-21 11:13   ` Alexandru Elisei
2023-03-15 11:07 ` [kvm-unit-tests PATCH 6/6] arm: pmu-chain-promotion: Increase the count and margin values Eric Auger
2023-04-04  6:23 ` [kvm-unit-tests PATCH 0/6] arm: pmu: Fix random failures of pmu-chain-promotion Eric Auger
2023-04-04 12:47   ` Andrew Jones
2023-04-12  7:34     ` Andrew Jones
2023-04-12  8:55       ` Alexandru Elisei [this message]
2023-04-12  8:47     ` Mark Rutland
2023-04-19  7:32       ` Eric Auger
2023-04-19  9:39         ` Alexandru Elisei
2023-04-21  8:11           ` Eric Auger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZDZx9uPIZVKEhQTw@monolith.localdoman \
    --to=alexandru.elisei@arm.com \
    --cc=andrew.jones@linux.dev \
    --cc=eric.auger.pro@gmail.com \
    --cc=eric.auger@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=kvmarm@lists.linux.dev \
    --cc=maz@kernel.org \
    --cc=oliver.upton@linux.dev \
    --cc=reijiw@google.com \
    --cc=ricarkol@google.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox