From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 505E9C77B78 for ; Wed, 26 Apr 2023 17:22:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232457AbjDZRWN (ORCPT ); Wed, 26 Apr 2023 13:22:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45376 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231331AbjDZRWM (ORCPT ); Wed, 26 Apr 2023 13:22:12 -0400 Received: from out-58.mta1.migadu.com (out-58.mta1.migadu.com [IPv6:2001:41d0:203:375::3a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 13AC32701 for ; Wed, 26 Apr 2023 10:22:08 -0700 (PDT) Date: Wed, 26 Apr 2023 17:21:58 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1682529725; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=yLWhzFr0IaFOP7oGWZVxeoPyLpaGebSmTPqngfIpZG0=; b=fX1xUvV2g81JM+0ABsdRcIjDsB/4E25/qjtfu0mosg0PvfMF9EHtEmDRZTz3iFWTYkK0dA 19FAfDwYGMolyePLVnuvhqZX1xWo1FbUgjHuNPt4/BF+tVLHSMDVjtXDd0o5kYB6/qHrji BF94HvG+MfWGhmnvQOaFbIcWpIUF+yQ= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Oliver Upton To: David Matlack Cc: Paolo Bonzini , Marc Zyngier , James Morse , Suzuki K Poulose , Zenghui Yu , Huacai Chen , Aleksandar Markovic , Anup Patel , Atish Patra , Paul Walmsley , Palmer Dabbelt , Albert Ou , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , David Hildenbrand , Sean Christopherson , Michael Ellerman , Eric Farman , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= , Sathvika Vasireddy , Nicholas Piggin , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-mips@vger.kernel.org, kvm@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH v2 0/4] KVM: Refactor KVM stats macros and enable custom stat names Message-ID: References: <20230306190156.434452-1-dmatlack@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230306190156.434452-1-dmatlack@google.com> X-Migadu-Flow: FLOW_OUT Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Mon, Mar 06, 2023 at 11:01:52AM -0800, David Matlack wrote: > This series refactors the KVM stats macros to reduce duplication and > adds the support for choosing custom names for stats. > > Custom name makes it possible to decouple the userspace-visible stat > names from their internal representation in C. This can allow future > commits to refactor the various stats structs without impacting > userspace tools that read KVM stats. > > This also allows stats to be stored in data structures such as arrays, > without needing unions to access specific stats. Case in point, the last > patch in this series removes the pages_{4k,2m,1g} union, which is a > useful cleanup to prepare for sharing paging code across architectures > [1]. > > And for full transparency, another motivation for this series it that at > Google we have several out-of-tree stats that use arrays. Custom name > support is something we added internally and it reduces our technical > debt to get the support merged upstream. For the series: Reviewed-by: Oliver Upton -- Thanks, Oliver