From: Jason Gunthorpe <jgg@nvidia.com>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: "Yan Zhao" <yan.y.zhao@intel.com>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
kevin.tian@intel.com, yishaih@nvidia.com,
shameerali.kolothum.thodi@huawei.com,
"Cédric Le Goater" <clg@redhat.com>
Subject: Re: [PATCH] vfio/pci: take mmap write lock for io_remap_pfn_range
Date: Thu, 11 May 2023 14:47:48 -0300 [thread overview]
Message-ID: <ZF0qRLtteE4mtRdT@nvidia.com> (raw)
In-Reply-To: <20230511100706.63d420db.alex.williamson@redhat.com>
On Thu, May 11, 2023 at 10:07:06AM -0600, Alex Williamson wrote:
> > I vaugely remember the address_space conversion might help remove the
> > fault handler?
>
> Yes, this did remove the fault handler entirely, it's (obviously)
> dropped off my radar, but perhaps in the interim we could switch to
> vmf_insert_pfn() and revive the address space series to eventually
> remove the fault handling and vma list altogether.
vmf_insert_pfn() technically isn't supposed to be used for MMIO..
Eg it doesn't do the PAT stuff on x86 that is causing this problem in
the first place.
So doing the address space removing series seems like the best fix. It
has been mislocked for a long time, I suspect there isn't a real
urgent problem beyond we actually have lockdep annoations to catch the
mislocking now.
Jason
next prev parent reply other threads:[~2023-05-11 17:47 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-08 12:58 [PATCH] vfio/pci: take mmap write lock for io_remap_pfn_range Yan Zhao
2023-05-08 16:48 ` Jason Gunthorpe
2023-05-08 20:57 ` Alex Williamson
2023-05-10 20:41 ` Jason Gunthorpe
2023-05-11 6:56 ` Yan Zhao
2023-05-11 7:38 ` Cédric Le Goater
2023-05-11 7:32 ` Cédric Le Goater
2023-05-11 16:07 ` Alex Williamson
2023-05-11 17:47 ` Jason Gunthorpe [this message]
2023-05-12 8:02 ` Yan Zhao
2024-05-22 16:56 ` Andrew Jones
2024-05-22 17:50 ` Alex Williamson
2024-05-22 18:30 ` Jason Gunthorpe
2024-05-22 19:43 ` Alex Williamson
2024-05-22 21:21 ` Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZF0qRLtteE4mtRdT@nvidia.com \
--to=jgg@nvidia.com \
--cc=alex.williamson@redhat.com \
--cc=clg@redhat.com \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=yan.y.zhao@intel.com \
--cc=yishaih@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox