From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2DBD1C77B75 for ; Fri, 5 May 2023 15:48:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232803AbjEEPsl (ORCPT ); Fri, 5 May 2023 11:48:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44618 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232012AbjEEPsi (ORCPT ); Fri, 5 May 2023 11:48:38 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7D67959D8 for ; Fri, 5 May 2023 08:47:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1683301675; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hQobjkXCgk5uy3vBplD0U6FyzeEdp0Sx4RLjpDbb7I8=; b=at2z/3IbRTFkvHKsRxE0QEqD8MvdHu2yrmFqe9mDN7v/xYRDqlizKed0hGjvaUoLjz803N o/nAnP06keNnvAmpZTB2Fvh4/xsdi377sB+XZK+0AAUBV/2oKdN3TP/nGHX0goLd7UMQyB MgoCzap9su7khKjFe/aLHnLN8AaHZyU= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-584-l-v661S2Ooy26swHv9Pw_g-1; Fri, 05 May 2023 11:47:52 -0400 X-MC-Unique: l-v661S2Ooy26swHv9Pw_g-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 0A3A53815EED; Fri, 5 May 2023 15:47:52 +0000 (UTC) Received: from redhat.com (unknown [10.42.28.42]) by smtp.corp.redhat.com (Postfix) with ESMTPS id AA78E1121331; Fri, 5 May 2023 15:47:50 +0000 (UTC) Date: Fri, 5 May 2023 16:47:48 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: =?utf-8?B?SsO2cmcgUsO2ZGVs?= Cc: Claudio Carvalho , Tom Lendacky , amd-sev-snp@lists.suse.com, linux-coco@lists.linux.dev, kvm@vger.kernel.org, Carlos Bilbao , Klaus Kiwi Subject: Re: [ANNOUNCEMENT] COCONUT Secure VM Service Module for SEV-SNP Message-ID: Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= References: <4420d7e5-d05f-8c31-a0f2-587ebb7eaa20@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/2.2.9 (2022-11-12) X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Fri, May 05, 2023 at 05:34:20PM +0200, Jörg Rödel wrote: > Hi Claudio, > > On Wed, May 03, 2023 at 12:51:17PM -0400, Claudio Carvalho wrote: > > Thanks. I would be happy to collaborate in that discussion. > > Great, I will send out that email early next week to get the discussion > rolling. > > > I think the crypto support requires more design discussion since it is required > > in multiple places. > > > > The experience I've had adding SVSM-vTPM support is that the SVSM needs crypto > > for requesting an attestation report (SNP_GUEST_REQUEST messages sent to the > > security processor PSP have to be encrypted with AES_GCM) and the vTPM also > > needs crypto for the TPM crypto operations. We could just duplicate the crypto > > library, or find a way to share it (e.g. vdso approach). > > > > For the SVSM, it would be rust code talking to the crypto library; for the vTPM > > it would be the vTPM (most likely an existing C implementation) talking to the > > crypto library. > > Right, where to place and how to share the crypto code needs more > discussion, there are multiple possible approaches. I have seen that you > have a talk at KVM Forum, so we can meet there in a larger group and > discuss those and other questions in person. Yep, we should probably do a BoF session on the topic of SVSM for anyone interested who's attending KVM Forum. With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|