From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 673FDC77B73 for ; Wed, 24 May 2023 19:10:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233664AbjEXTKd (ORCPT ); Wed, 24 May 2023 15:10:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40272 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233390AbjEXTK3 (ORCPT ); Wed, 24 May 2023 15:10:29 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 21A5A12B for ; Wed, 24 May 2023 12:09:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1684955381; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=RLt1jUkMRuYsgAKC2Cdank6FFEsvFTMJq5xzMGDDBh0=; b=heNqXiv+F9HsD5KzUCTWY4NkrdiPCtSLoQbA3zOdz2cVC00H9E5B4Bb5ywMcQunH8W18Ny aXEFY3bhmLuiB69Qay0HhbeXsqQMz0p3EYzHqGve8h41moaWbOjnaxoe6dM3GAdP/SgnzK I1Fe0PJqoEwot8gJ1l9JJxQUR6M4G04= Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-414-sS7jWGssPc-PW627ciiBIQ-1; Wed, 24 May 2023 15:09:35 -0400 X-MC-Unique: sS7jWGssPc-PW627ciiBIQ-1 Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-3f386bb966cso2224771cf.1 for ; Wed, 24 May 2023 12:09:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684955375; x=1687547375; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=RLt1jUkMRuYsgAKC2Cdank6FFEsvFTMJq5xzMGDDBh0=; b=XSvw3s1N3M3PQL3SCu1EZmrZafm8YCUGXFLdaPIX8JozVn7NOTBbUgWFv8bBHtpkjb oEdDEV3mK2Wojr7zZUkiDK/t2lkbKPEr08xyxI7Ptrp51AgtNtuWb14fvFxu5ilRDGX6 6Ia+ycQNQqwB8dcLrDsp1IJDtZNdHNHDhRmL8DEW7d6TDS5iQd714PBKoIEjSU3i9dwn 0rCxFZLsgAkwOvlFLAAbGEJWAuSrFBIgtCFVkbLj4CkTwl2QStbbZyQZNFxIjZM1YIiG CdsHJ2pvoNNldtFwFZSyXDRipngYQ9bB2rPOc1moK1+VxHMrfWi6tC2Bc1K3NYbpPBGf IiNg== X-Gm-Message-State: AC+VfDxKUb0p6gKQYZyXEyK5O9Va/xBOExOJZ8lPF4uxQsOfFzdonyVM 2MvPDxG2p9AdDID61BPiRB5Ag1bzKpeH/hHCsVdV5Ig/P8Yzpt0K3VHxW8gnsvDgXh/C5tV8wN4 o+Z329XO1kvLf X-Received: by 2002:a05:622a:1a91:b0:3f4:fdaa:8e14 with SMTP id s17-20020a05622a1a9100b003f4fdaa8e14mr4565644qtc.2.1684955375207; Wed, 24 May 2023 12:09:35 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7BwuqNh4b6tgKt0w1lmfeAbL8sRjfw3morvt4PO25eB8mOzI2e/Sm85Z9xwtVdn4gN42cjgA== X-Received: by 2002:a05:622a:1a91:b0:3f4:fdaa:8e14 with SMTP id s17-20020a05622a1a9100b003f4fdaa8e14mr4565606qtc.2.1684955374809; Wed, 24 May 2023 12:09:34 -0700 (PDT) Received: from x1n (bras-base-aurron9127w-grc-62-70-24-86-62.dsl.bell.ca. [70.24.86.62]) by smtp.gmail.com with ESMTPSA id r11-20020ac85e8b000000b003f6be76a5c1sm1315507qtx.6.2023.05.24.12.09.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 May 2023 12:09:34 -0700 (PDT) Date: Wed, 24 May 2023 15:09:33 -0400 From: Peter Xu To: Sean Christopherson Cc: David Stevens , Marc Zyngier , Oliver Upton , Paolo Bonzini , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, kvm@vger.kernel.org Subject: Re: [PATCH v6 1/4] KVM: mmu: introduce new gfn_to_pfn_noref functions Message-ID: References: <20230330085802.2414466-1-stevensd@google.com> <20230330085802.2414466-2-stevensd@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Wed, May 24, 2023 at 11:29:45AM -0700, Sean Christopherson wrote: > On Wed, May 24, 2023, Peter Xu wrote: > > On Wed, May 24, 2023 at 09:46:13AM -0700, Sean Christopherson wrote: > > > If we hack kvm_pfn_to_refcounted_page(), then all of those protections are lost > > > because KVM would drop its assertions and also skip dirtying pages, i.e. would > > > effectively suppress the latent detection by check_new_page_bad(). > > > > So it's probably that I totally have no idea what are the attributes for > > those special pages so I don't understand enough on why we need to handle > > those pages differently from e.g. PFNMAP pages, and also the benefits. > > > > I think what I can tell is that they're pages that doesn't have > > PageCompound bits set on either head or tails, however it's still a > > multi-2-order large page. Is there an example on how these pages are used > > and allocated? Why would we need those pages, and whether these pages need > > to be set dirty/accessed after all? > > The use case David is interested in is where an AMD GPU driver kmallocs() a > chunk of memory, let's it be mmap()'d by userspace, and userspace then maps it > into the guest for a virtual (passthrough?) GPU. For all intents and purposes, > it's normal memory, just not refcounted. I'm not familiar enough with kmalloc, but what I think is kmalloc for large chunks will be the same as alloc_pages, and I thought it should also be a compound page already. If that needs to be mmap()ed to userapp then I assume it mostly should be kmalloc_large(). kmalloc -> kmalloc_large -> __kmalloc_large_node: flags |= __GFP_COMP; Then when the new page allocated and being prepared (prep_new_page): if (order && (gfp_flags & __GFP_COMP)) prep_compound_page(page, order); I assume prep_compound_page() will make PageCompound return true for those pages returned. So I know I still miss something, but not sure where.. because IIRC we're at least talking about !PageCompound pages. > > > > static bool kvm_is_ad_tracked_page(struct page *page) > > > { > > > + /* > > > + * Assert that KVM isn't attempting to mark a freed page as Accessed or > > > + * Dirty, i.e. that KVM's MMU doesn't have a use-after-free bug. KVM > > > + * (typically) doesn't pin pages that are mapped in KVM's MMU, and > > > + * instead relies on mmu_notifiers to know when a mapping needs to be > > > + * zapped/invalidated. Unmapping from KVM's MMU must happen _before_ > > > + * KVM returns from its mmu_notifier, i.e. the page should have an > > > + * elevated refcount at this point even though KVM doesn't hold a > > > + * reference of its own. > > > + */ > > > + if (WARN_ON_ONCE(!page_count(page))) > > > + return false; > > > + > > > /* > > > * Per page-flags.h, pages tagged PG_reserved "should in general not be > > > * touched (e.g. set dirty) except by its owner". > > > > > > > This looks like a good thing to have, indeed. But again it doesn't seem > > like anything special to the pages we're discussing here, say, !Compound && > > refcount==0 ones. > > The problem is that if KVM ignores refcount==0 pages, then KVM can't distinguish > between the legitimate[*] refcount==0 AMD GPU case and a buggy refcount==0 > use-after-free scenario. I don't want to make that sacrifice as the legimiate > !refcounted use case is a very specific use case, whereas consuming refcounted > memory is ubiquituous (outside of maybe AWS). > > [*] Consuming !refcounted pages is safe only for flows that are tied into the > mmu_notifiers. The current proposal/plan is to add an off-by-default module > param that let's userspace opt-in to kmap() use of !refcounted memory, e.g. > this case and PFNMAP memory. I see. I think you mentioned that we can use one special bit in the shadow pte to mark such special pages. Does it mean that your above patch will still cover what you wanted to protect even if we use the trick? Because then kvm_is_ad_tracked_page() should only be called when we're sure the special bit is not set. IOW, we can still rule out these pages already and page_count()==0 check here can still be helpful to track kvm bugs? -- Peter Xu