From: Sean Christopherson <seanjc@google.com>
To: Binbin Wu <binbin.wu@linux.intel.com>
Cc: kvm@vger.kernel.org, pbonzini@redhat.com
Subject: Re: [PATCH 1/2] KVM: Fix comments for KVM_ENABLE_CAP
Date: Wed, 17 May 2023 14:26:42 -0700 [thread overview]
Message-ID: <ZGVGkpvWQqLX2BrV@google.com> (raw)
In-Reply-To: <20230423101112.13803-2-binbin.wu@linux.intel.com>
On Sun, Apr 23, 2023, Binbin Wu wrote:
Please write a changelog, I'm not willing to trudge through KVM's capability mess
to determine whether or not this is correct without some effort on your part to
point me in the right direction.
> Signed-off-by: Binbin Wu <binbin.wu@linux.intel.com>
> ---
> include/uapi/linux/kvm.h | 2 +-
> tools/include/uapi/linux/kvm.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/uapi/linux/kvm.h b/include/uapi/linux/kvm.h
> index 4003a166328c..1a5cc4c6b59b 100644
> --- a/include/uapi/linux/kvm.h
> +++ b/include/uapi/linux/kvm.h
> @@ -1605,7 +1605,7 @@ struct kvm_s390_ucas_mapping {
> #define KVM_GET_DEBUGREGS _IOR(KVMIO, 0xa1, struct kvm_debugregs)
> #define KVM_SET_DEBUGREGS _IOW(KVMIO, 0xa2, struct kvm_debugregs)
> /*
> - * vcpu version available with KVM_ENABLE_CAP
> + * vcpu version available with KVM_CAP_ENABLE_CAP
> * vm version available with KVM_CAP_ENABLE_CAP_VM
> */
> #define KVM_ENABLE_CAP _IOW(KVMIO, 0xa3, struct kvm_enable_cap)
> diff --git a/tools/include/uapi/linux/kvm.h b/tools/include/uapi/linux/kvm.h
> index 4003a166328c..1a5cc4c6b59b 100644
> --- a/tools/include/uapi/linux/kvm.h
> +++ b/tools/include/uapi/linux/kvm.h
Unless someone objects, please drop the tools/ change and let the perf folks deal
with their mess.
https://lore.kernel.org/all/Y8bZ%2FJ98V5i3wG%2Fv@google.com
next prev parent reply other threads:[~2023-05-17 21:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-23 10:11 [PATCH 0/2] KVM: Fix some comments Binbin Wu
2023-04-23 10:11 ` [PATCH 1/2] KVM: Fix comments for KVM_ENABLE_CAP Binbin Wu
2023-05-17 21:26 ` Sean Christopherson [this message]
2023-04-23 10:11 ` [PATCH 2/2] KVM: x86: Fix some comments Binbin Wu
2023-05-17 21:28 ` Sean Christopherson
2023-05-18 5:20 ` Binbin Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZGVGkpvWQqLX2BrV@google.com \
--to=seanjc@google.com \
--cc=binbin.wu@linux.intel.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox