From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA42AC77B7A for ; Tue, 30 May 2023 17:14:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233056AbjE3ROV (ORCPT ); Tue, 30 May 2023 13:14:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46566 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231551AbjE3ROT (ORCPT ); Tue, 30 May 2023 13:14:19 -0400 Received: from mail-pf1-x449.google.com (mail-pf1-x449.google.com [IPv6:2607:f8b0:4864:20::449]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 90EC3F1 for ; Tue, 30 May 2023 10:14:17 -0700 (PDT) Received: by mail-pf1-x449.google.com with SMTP id d2e1a72fcca58-64d5b4c4484so3113761b3a.3 for ; Tue, 30 May 2023 10:14:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1685466857; x=1688058857; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=oW5kBn+PdJEe6rnXOx+ck1CwnlYyJC8NqkWMcNa5q8w=; b=5tqIC4aQWleru/7zEQ0O/WXJ4FaBYf8tAGYm6xgyYMK7b5MfPQD9AYDQ4YYAtrWSov sBHidJlws2X4SVko9faCr5yMOkwlEig9tMKy1cR+PrS6TJ//Uby+sck61oO29XO31jl1 OxwY51SC8xVggRqjPel2Md8LNUuwnqlXJ8x5DG0An4gTYsKEmprDK736L5gwekv/MiWL VD0mRxnXpuF+S0DWCgL590UkgyZj3C69nzVCIaiB7+es2moWAfLtqrydqaEhdQyvJw7+ IA23MdOc3WAECAZjKkoJe1yglPb6B+6MjV4nKmKwToSLcfLOlPTZBOqJf64uEpk0NQsl i6EQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685466857; x=1688058857; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=oW5kBn+PdJEe6rnXOx+ck1CwnlYyJC8NqkWMcNa5q8w=; b=D5+iikjC0cXahVhGd+XHKu+JhTNxT788/pc3JOhlrRM3+EVtG/AKx2mzu/XDvPyj7g iOXCH4kUfkch+3kJlGcxCWlCpvNj9sr/T9ahTq4yn4G4Ya0/O4Vs9Lqk3hZerEmSX/hc ara232jVL63cfEvyuJd9s/kqOkb2t8kZMVt2saau6p3svr+1cV7JlYuQ1KonP/T869hY EJl94ZdGFi8iY4ll1moV1az+qyt8N63Ls4QzdLNK/EaXsWrpCLphvXqe91w6Zd0UU/cu Fo6ICYO2iVv2aMCQCuZUYh/J+juVfzvzox5pM7hAczuS+H5UROD3J8/CUtbN8cHB13Dh qLlw== X-Gm-Message-State: AC+VfDzgX5CnQ7ywrrb6WIg1MS5a+4x3IpOIPLtDWciYGhdiYlCXamEB r+4u/dP5iyvgyXFSBNc5g2+q/oakaDQ= X-Google-Smtp-Source: ACHHUZ7Yj3FRLJmuyE2r93i9n0+xfvuQ5ZojKX+qIj+lPi2L12IcMOFH/kvwC3UzWxnLDX34U4WpmBgLQac= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a05:6a00:a0e:b0:643:53b6:d86d with SMTP id p14-20020a056a000a0e00b0064353b6d86dmr1072552pfh.4.1685466857070; Tue, 30 May 2023 10:14:17 -0700 (PDT) Date: Tue, 30 May 2023 10:14:15 -0700 In-Reply-To: <20230530215036.000066d9.zhi.wang.linux@gmail.com> Mime-Version: 1.0 References: <20230530215036.000066d9.zhi.wang.linux@gmail.com> Message-ID: Subject: Re: [PATCH v14 004/113] KVM: TDX: Initialize the TDX module when loading the KVM intel kernel module From: Sean Christopherson To: Zhi Wang Cc: isaku.yamahata@intel.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, isaku.yamahata@gmail.com, Paolo Bonzini , erdemaktas@google.com, Sagi Shahar , David Matlack , Kai Huang , chen.bo@intel.com Content-Type: text/plain; charset="us-ascii" Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Tue, May 30, 2023, Zhi Wang wrote: > On Sun, 28 May 2023 21:18:46 -0700 isaku.yamahata@intel.com wrote: > > + /* tdx_enable() in tdx_module_setup() requires cpus lock. */ > > + cpus_read_lock(); > > + on_each_cpu(vmx_tdx_on, &err, true); /* TDX requires vmxon. */ > > + r = atomic_read(&err); > > + if (!r) > > + r = tdx_module_setup(); > > + on_each_cpu(vmx_off, NULL, true); > > Out of curiosity, why VMX has to be turned off after tdx_module_setup()? KVM has historically enabled VMX if and only if KVM has active VMs. Whether or not it still makes sense to do dynamic enabling is debatable, but that's a discussion for another day.