From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 111A9C77B7A for ; Thu, 1 Jun 2023 16:21:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231319AbjFAQVB (ORCPT ); Thu, 1 Jun 2023 12:21:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43394 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231192AbjFAQU7 (ORCPT ); Thu, 1 Jun 2023 12:20:59 -0400 Received: from mail-yw1-x1149.google.com (mail-yw1-x1149.google.com [IPv6:2607:f8b0:4864:20::1149]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DCB05134 for ; Thu, 1 Jun 2023 09:20:58 -0700 (PDT) Received: by mail-yw1-x1149.google.com with SMTP id 00721157ae682-561eb6c66f6so14519927b3.0 for ; Thu, 01 Jun 2023 09:20:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1685636456; x=1688228456; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=I8MtW2Q7n+8kVk0jNDBvQTtFEDaPcuPqWej2hGKW7Ww=; b=ajNXyHBOUOC4trVOpRJKJj1vcm+0E379aucFQj2qjWrtdK8kMcjJVq6bwo/QPJJpsf ixvGSXMSfV0z2Bk5Ec41a/v8skxddaBMr7chx4+mg9OK4C3WscU7DpDW+2Ts2pBLCPhK KBGyb8U780xfJMXEN041JZvhKVFCH9McPcVt8xQ+UgtC8IaFVp1yh8+qXsdOPQxRiIep cU46b/x8Sk0XBsoT2T7yMeZA66gdwKQnzimTkyBuveQ/qMTBw49LpeAPlQleXRLYVlu3 AMJ9WO7BiKhuv8+CTqgLwSHlSyAUID3JKCDsgcrldqjoUPsiTOFAVlTJF3Fb4ubz/pGX isGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685636456; x=1688228456; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=I8MtW2Q7n+8kVk0jNDBvQTtFEDaPcuPqWej2hGKW7Ww=; b=W5D3hdvEuXah874omUrFwe2wF2ZsBfaHcYL04GIbIsjebkVEqkt0/W+dBmKQL3tlER n5dC0OfCBgAq6VEcYhlfrZs8BqG7Dg0QXQ2MLNUYRmMnc+cmxdiPlSSgj0XIO3sEoIOz b/56gTlaPLPyTYtcizmCMMkbgHf+lT+iNy8dYIvtKdQ3sxZTAsmFLLZEXiI/ozrDMK0K bY2K+NJKzzYiVXwY02enVO6+mhdPkzBXOw6bhuQokyIPo352IKiOmlc4sH1thNcZo9Bh SvrfwspsY/bSZZvwue905GJnctMTzCO5g0IrgLmoBvTtCxoIPUeBTvIufff4KuoxTodl 4Ckg== X-Gm-Message-State: AC+VfDzR33GARqsxRIY7EjhrASBMgHsbBLJe2h8QVV3ALcxUsah59rJC NlopqgVaLwSRYO5l3bRdbYbtsvwwFhs= X-Google-Smtp-Source: ACHHUZ6YvIG3cYXg02rNK4YX0kLcjPJqydSFn7vmiEQVEqNHhuwarV6iA3Sv8RueaV8SWnVS5rkfcHytUGk= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a81:ad5c:0:b0:565:b7d6:712d with SMTP id l28-20020a81ad5c000000b00565b7d6712dmr5681145ywk.2.1685636456512; Thu, 01 Jun 2023 09:20:56 -0700 (PDT) Date: Thu, 1 Jun 2023 09:20:54 -0700 In-Reply-To: Mime-Version: 1.0 References: <20230307135233.54684-1-wei.w.wang@intel.com> Message-ID: Subject: Re: [PATCH v2] KVM: allow KVM_BUG/KVM_BUG_ON to handle 64-bit cond From: Sean Christopherson To: Wei W Wang Cc: "dmatlack@google.com" , "mizhang@google.com" , "isaku.yamahata@gmail.com" , "pbonzini@redhat.com" , "kvm@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="us-ascii" Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Thu, Jun 01, 2023, Wei W Wang wrote: > On Thursday, March 9, 2023 7:26 AM, Sean Christopherson wrote: > > On Tue, Mar 07, 2023, Wei Wang wrote: > > > Current KVM_BUG and KVM_BUG_ON assume that 'cond' passed from > > callers > > > is 32-bit as it casts 'cond' to the type of int. > > > > You're very generous, I would have led with "Fix a badly done > > copy+paste ..." ;-) > > > > > Fixes: 0b8f11737cff ("KVM: Add infrastructure and macro to mark VM as > > > bugged") > > > Signed-off-by: Wei Wang > > > --- > > > > Reviewed-by: Sean Christopherson > > Kind ping on this patch. > Seems it wasn't noticed for months. Just check if it would be good to be > merged or not proper for any reason? I'll grab it for 6.5.