From: Jason Gunthorpe <jgg@nvidia.com>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: Kevin Tian <kevin.tian@intel.com>,
kvm@vger.kernel.org, Longfang Liu <liulongfang@huawei.com>,
Shameer Kolothum <shameerali.kolothum.thodi@huawei.com>,
Yishai Hadas <yishaih@nvidia.com>
Subject: Re: [PATCH] vfio: Fixup kconfig ordering for VFIO_PCI_CORE
Date: Thu, 1 Jun 2023 17:48:27 -0300 [thread overview]
Message-ID: <ZHkEG28EFVDKVb/Z@nvidia.com> (raw)
In-Reply-To: <20230601144238.77c2ad29.alex.williamson@redhat.com>
On Thu, Jun 01, 2023 at 02:42:38PM -0600, Alex Williamson wrote:
> On Mon, 29 May 2023 14:47:59 -0300
> > +config VFIO_PCI_CORE
> > + tristate "VFIO support for PCI devices"
> > + select VFIO_VIRQFD
> > + select IRQ_BYPASS_MANAGER
> > + help
> > + Base support for VFIO drivers that support PCI devices. At least one
> > + of the implementation drivers must be selected.
>
> As enforced by what?
Doesn't need to be enforced. Probably should have said "should"
> This is just adding one more layer of dependencies in order to select
> the actual endpoint driver that is actually what anyone cares about.
This is making the kconfig more logical and the menu structure better
organized. We eliminate the need for the drivers to set special
depends because the if covers them all.
> I don't see why we wouldn't just make each of the variant drivers
> select VFIO_PCI_CORE. Thanks,
It can be done, but it seems more fragile.
Jason
next prev parent reply other threads:[~2023-06-01 20:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-29 17:47 [PATCH] vfio: Fixup kconfig ordering for VFIO_PCI_CORE Jason Gunthorpe
2023-06-01 20:42 ` Alex Williamson
2023-06-01 20:48 ` Jason Gunthorpe [this message]
2023-06-01 21:48 ` Alex Williamson
2023-06-01 22:45 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZHkEG28EFVDKVb/Z@nvidia.com \
--to=jgg@nvidia.com \
--cc=alex.williamson@redhat.com \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=liulongfang@huawei.com \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=yishaih@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox