From: Oliver Upton <oliver.upton@linux.dev>
To: Reiji Watanabe <reijiw@google.com>
Cc: Marc Zyngier <maz@kernel.org>,
kvmarm@lists.linux.dev, kvm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
James Morse <james.morse@arm.com>,
Alexandru Elisei <alexandru.elisei@arm.com>,
Zenghui Yu <yuzenghui@huawei.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Jing Zhang <jingzhangos@google.com>,
Raghavendra Rao Anata <rananta@google.com>
Subject: Re: [PATCH 1/2] KVM: arm64: PMU: Introduce pmu_v3_is_supported() helper
Date: Sat, 10 Jun 2023 18:10:48 -0700 [thread overview]
Message-ID: <ZIUfGJwVCO0y0lgQ@linux.dev> (raw)
In-Reply-To: <20230610061520.3026530-2-reijiw@google.com>
On Fri, Jun 09, 2023 at 11:15:19PM -0700, Reiji Watanabe wrote:
> Introduce pmu_v3_is_supported() helper to check if the given
> PMUVer supports PMUv3, and use it instead of open coding it.
>
> Signed-off-by: Reiji Watanabe <reijiw@google.com>
> ---
> arch/arm64/kvm/pmu-emul.c | 3 +--
> arch/arm64/kvm/sys_regs.c | 2 +-
> include/kvm/arm_pmu.h | 8 ++++++++
> 3 files changed, 10 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm64/kvm/pmu-emul.c b/arch/arm64/kvm/pmu-emul.c
> index 491ca7eb2a4c..5d2903f52a5f 100644
> --- a/arch/arm64/kvm/pmu-emul.c
> +++ b/arch/arm64/kvm/pmu-emul.c
> @@ -672,8 +672,7 @@ void kvm_host_pmu_init(struct arm_pmu *pmu)
> {
> struct arm_pmu_entry *entry;
>
> - if (pmu->pmuver == ID_AA64DFR0_EL1_PMUVer_NI ||
> - pmu->pmuver == ID_AA64DFR0_EL1_PMUVer_IMP_DEF)
> + if (!pmu_v3_is_supported(pmu->pmuver))
> return;
Why not use pmuv3_implemented()?
--
Thanks,
Oliver
next prev parent reply other threads:[~2023-06-11 1:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-10 6:15 [PATCH 0/2] KVM: arm64: PMU: Disallow vPMU on non-uniform PMUVer systems Reiji Watanabe
2023-06-10 6:15 ` [PATCH 1/2] KVM: arm64: PMU: Introduce pmu_v3_is_supported() helper Reiji Watanabe
2023-06-11 1:10 ` Oliver Upton [this message]
2023-06-10 6:15 ` [PATCH 2/2] KVM: arm64: PMU: Disallow vPMU on non-uniform PMUVer systems Reiji Watanabe
2023-06-11 2:32 ` Oliver Upton
2023-06-11 5:03 ` Reiji Watanabe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZIUfGJwVCO0y0lgQ@linux.dev \
--to=oliver.upton@linux.dev \
--cc=alexandru.elisei@arm.com \
--cc=james.morse@arm.com \
--cc=jingzhangos@google.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=maz@kernel.org \
--cc=rananta@google.com \
--cc=reijiw@google.com \
--cc=suzuki.poulose@arm.com \
--cc=yuzenghui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox