* [PATCH] kvm: vmx: fix a trivial comment in vmx_vcpu_after_set_cpuid()
@ 2023-07-25 10:08 Yi Wang
2023-07-25 14:52 ` Sean Christopherson
0 siblings, 1 reply; 2+ messages in thread
From: Yi Wang @ 2023-07-25 10:08 UTC (permalink / raw)
To: seanjc, pbonzini, tglx, mingo, bp, dave.hansen, hpa
Cc: kvm, linux-kernel, wanpengli, Yi Wang
The commit b6247686b7571 ("KVM: VMX: Drop caching of KVM's desired
sec exec controls for vmcs01") renamed vmx_compute_secondary_exec_control()
to vmx_secondary_exec_control(), but forgot to modify the comment.
Signed-off-by: Yi Wang <foxywang@tencent.com>
---
arch/x86/kvm/vmx/vmx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c
index 0ecf4be2c6af..26d62990fea7 100644
--- a/arch/x86/kvm/vmx/vmx.c
+++ b/arch/x86/kvm/vmx/vmx.c
@@ -7722,7 +7722,7 @@ static void vmx_vcpu_after_set_cpuid(struct kvm_vcpu *vcpu)
{
struct vcpu_vmx *vmx = to_vmx(vcpu);
- /* xsaves_enabled is recomputed in vmx_compute_secondary_exec_control(). */
+ /* xsaves_enabled is recomputed in vmx_secondary_exec_control(). */
vcpu->arch.xsaves_enabled = false;
vmx_setup_uret_msrs(vmx);
--
2.39.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] kvm: vmx: fix a trivial comment in vmx_vcpu_after_set_cpuid()
2023-07-25 10:08 [PATCH] kvm: vmx: fix a trivial comment in vmx_vcpu_after_set_cpuid() Yi Wang
@ 2023-07-25 14:52 ` Sean Christopherson
0 siblings, 0 replies; 2+ messages in thread
From: Sean Christopherson @ 2023-07-25 14:52 UTC (permalink / raw)
To: Yi Wang
Cc: pbonzini, tglx, mingo, bp, dave.hansen, hpa, kvm, linux-kernel,
wanpengli, Yi Wang
On Tue, Jul 25, 2023, Yi Wang wrote:
> The commit b6247686b7571 ("KVM: VMX: Drop caching of KVM's desired
> sec exec controls for vmcs01") renamed vmx_compute_secondary_exec_control()
> to vmx_secondary_exec_control(), but forgot to modify the comment.
>
> Signed-off-by: Yi Wang <foxywang@tencent.com>
> ---
> arch/x86/kvm/vmx/vmx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c
> index 0ecf4be2c6af..26d62990fea7 100644
> --- a/arch/x86/kvm/vmx/vmx.c
> +++ b/arch/x86/kvm/vmx/vmx.c
> @@ -7722,7 +7722,7 @@ static void vmx_vcpu_after_set_cpuid(struct kvm_vcpu *vcpu)
> {
> struct vcpu_vmx *vmx = to_vmx(vcpu);
>
> - /* xsaves_enabled is recomputed in vmx_compute_secondary_exec_control(). */
> + /* xsaves_enabled is recomputed in vmx_secondary_exec_control(). */
> vcpu->arch.xsaves_enabled = false;
I have an in-progress patch[*] that reworks this code and wipes out the stale
comment as a side effect. Thank you though!
[*] https://lore.kernel.org/all/20230217231022.816138-4-seanjc@google.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-07-25 14:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-25 10:08 [PATCH] kvm: vmx: fix a trivial comment in vmx_vcpu_after_set_cpuid() Yi Wang
2023-07-25 14:52 ` Sean Christopherson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox