Kernel KVM virtualization development
 help / color / mirror / Atom feed
From: Chao Gao <chao.gao@intel.com>
To: Jim Mattson <jmattson@google.com>,
	Pawan Gupta <pawan.kumar.gupta@linux.intel.com>
Cc: Xiaoyao Li <xiaoyao.li@intel.com>, kvm list <kvm@vger.kernel.org>
Subject: Re: KVM's sloppiness wrt IA32_SPEC_CTRL and IA32_PRED_CMD
Date: Fri, 21 Jul 2023 11:37:42 +0800	[thread overview]
Message-ID: <ZLn9hgQy77x0hLil@chao-email> (raw)
In-Reply-To: <CALMp9eSw9g0oRh7rT=Nd5aTwiu_zMz21tRrZG5D_QEfTn1h=HQ@mail.gmail.com>

On Thu, Jul 20, 2023 at 10:52:44AM -0700, Jim Mattson wrote:
>> And is it fair to good citizens that won't set reserved bits but will
>> suffer performance drop caused by the fix?
>
>Is it fair to other tenants of the host to have their data exfiltrated
>by a bad citizen, because KVM didn't control access to the MSR?

To be clear, I agree to intercept IA32_SPEC_CTRL MSR if allowing guests
to clear some bits puts host or other tenents at risk.

>> >As your colleague pointed out earlier, IA32_SPEC_CTRL.STIBP[bit 1] is
>> >such a bit. If the host has this bit set and you allow the guest to
>> >clear it, then you have compromised host security.

...

>>
>> If guest can compromise host security, I definitly agree to intercept
>> IA32_SPEC_CTRL MSR.
>
>I believe that when the decision was made to pass through this MSR for
>write, the assumption was that the host wouldn't ever use it (hence
>the host value would be zero). That assumption has not stood the test
>of time.

Could you elaborate on the security risk of guests' clearing
IA32_SPEC_CTRL.STIBP[bit 1] (or any other bit)? +Pawan

  reply	other threads:[~2023-07-21  3:38 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-19 18:08 KVM's sloppiness wrt IA32_SPEC_CTRL and IA32_PRED_CMD Jim Mattson
2023-07-20  1:25 ` Xiaoyao Li
2023-07-20  1:58   ` Chao Gao
2023-07-20  4:04     ` Xiaoyao Li
2023-07-20 10:38       ` Chao Gao
2023-07-20  4:04     ` Jim Mattson
2023-07-20  8:03       ` Chao Gao
2023-07-20 17:52         ` Jim Mattson
2023-07-21  3:37           ` Chao Gao [this message]
2023-07-21 19:01             ` Pawan Gupta
2023-07-21 19:18               ` Jim Mattson
2023-07-21 20:54                 ` Pawan Gupta
2023-07-21 22:18                   ` Jim Mattson
2023-07-21 22:29                     ` Pawan Gupta
2023-07-24 19:25                       ` Pawan Gupta
2023-07-24 20:01                         ` Jim Mattson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZLn9hgQy77x0hLil@chao-email \
    --to=chao.gao@intel.com \
    --cc=jmattson@google.com \
    --cc=kvm@vger.kernel.org \
    --cc=pawan.kumar.gupta@linux.intel.com \
    --cc=xiaoyao.li@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox