From: Simon Horman <simon.horman@corigine.com>
To: Brett Creeley <brett.creeley@amd.com>
Cc: kvm@vger.kernel.org, netdev@vger.kernel.org,
alex.williamson@redhat.com, jgg@nvidia.com, yishaih@nvidia.com,
shameerali.kolothum.thodi@huawei.com, kevin.tian@intel.com,
shannon.nelson@amd.com
Subject: Re: [PATCH v12 vfio 5/7] vfio/pds: Add support for dirty page tracking
Date: Tue, 25 Jul 2023 19:29:53 +0200 [thread overview]
Message-ID: <ZMAGkcIPnWs/+Y/B@corigine.com> (raw)
In-Reply-To: <20230719223527.12795-6-brett.creeley@amd.com>
On Wed, Jul 19, 2023 at 03:35:25PM -0700, Brett Creeley wrote:
...
> +static void pds_vfio_dirty_free_bitmaps(struct pds_vfio_dirty *dirty)
> +{
> + if (dirty->host_seq.bmp)
> + vfree(dirty->host_seq.bmp);
> + if (dirty->host_ack.bmp)
> + vfree(dirty->host_ack.bmp);
Hi Brett,
I don't think there is a need to guard these vfree calls,
as I think they will be no-ops with NULL arguments.
> +
> + dirty->host_seq.bmp = NULL;
> + dirty->host_ack.bmp = NULL;
> +}
...
next prev parent reply other threads:[~2023-07-25 17:30 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-19 22:35 [PATCH v12 vfio 0/7] pds-vfio-pci driver Brett Creeley
2023-07-19 22:35 ` [PATCH v12 vfio 1/7] vfio: Commonize combine_ranges for use in other VFIO drivers Brett Creeley
2023-07-21 8:51 ` Tian, Kevin
2023-07-22 7:05 ` Brett Creeley
2023-07-19 22:35 ` [PATCH v12 vfio 2/7] vfio/pds: Initial support for pds VFIO driver Brett Creeley
2023-07-21 8:53 ` Tian, Kevin
2023-07-22 7:06 ` Brett Creeley
2023-07-19 22:35 ` [PATCH v12 vfio 3/7] vfio/pds: register with the pds_core PF Brett Creeley
2023-07-21 9:01 ` Tian, Kevin
2023-07-22 7:09 ` Brett Creeley
2023-07-24 2:25 ` Tian, Kevin
2023-07-24 18:18 ` Brett Creeley
2023-07-24 13:00 ` Jason Gunthorpe
2023-07-24 18:20 ` Brett Creeley
2023-07-24 18:24 ` Jason Gunthorpe
2023-07-19 22:35 ` [PATCH v12 vfio 4/7] vfio/pds: Add VFIO live migration support Brett Creeley
2023-07-21 9:15 ` Tian, Kevin
2023-07-22 7:17 ` Brett Creeley
2023-07-24 2:30 ` Tian, Kevin
2023-07-24 12:58 ` Jason Gunthorpe
2023-07-24 21:39 ` Brett Creeley
2023-07-25 17:31 ` Simon Horman
2023-07-25 17:58 ` Brett Creeley
2023-07-19 22:35 ` [PATCH v12 vfio 5/7] vfio/pds: Add support for dirty page tracking Brett Creeley
2023-07-25 17:29 ` Simon Horman [this message]
2023-07-25 18:00 ` Brett Creeley
2023-07-19 22:35 ` [PATCH v12 vfio 6/7] vfio/pds: Add support for firmware recovery Brett Creeley
2023-07-19 22:35 ` [PATCH v12 vfio 7/7] vfio/pds: Add Kconfig and documentation Brett Creeley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZMAGkcIPnWs/+Y/B@corigine.com \
--to=simon.horman@corigine.com \
--cc=alex.williamson@redhat.com \
--cc=brett.creeley@amd.com \
--cc=jgg@nvidia.com \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=shannon.nelson@amd.com \
--cc=yishaih@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).