Re: [PATCH v2 6/8] mm/huge_memory: remove stale NUMA hinting comment from follow_trans_huge_pmd()

Mel Gorman
2023-08-02T15:41:06Z

On Tue, Aug 01, 2023 at 02:48:42PM +0200, David Hildenbrand wrote:
> That comment for pmd_protnone() was added in commit 2b4847e73004
> ("mm: numa: serialise parallel get_user_page against THP migration"), which
> noted:
>
> THP does not unmap pages due to a lack of support for migration
> entries at a PMD level. This allows races with get_user_pages
>
> Nowadays, we do have PMD migration entries, so the comment no longer
> applies. Let's drop it.
>
> Signed-off-by: David Hildenbrand <david@redhat.com>

Acked-by: Mel Gorman <mgorman@techsingularity.net>

--
Mel Gorman
SUSE Labs